From: Mario Limonciello <superm1@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Bert Karwatzki" <spasswolf@web.de>,
caleb.connolly@linaro.org, bhelgaas@google.com,
amit.pundir@linaro.org, neil.armstrong@linaro.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
"Praveenkumar Patil" <PraveenKumar.Patil@amd.com>
Subject: Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
Date: Mon, 8 Jul 2024 11:01:12 -0500 [thread overview]
Message-ID: <81a93b15-2791-4eec-8164-f141fae9a5f1@kernel.org> (raw)
In-Reply-To: <CAMRc=MdHSsctXYor2ycWqRJHCUciweRTie_TjW9h0yfN7wZhOA@mail.gmail.com>
On 7/8/2024 10:58, Bartosz Golaszewski wrote:
> On Mon, Jul 8, 2024 at 5:53 PM Mario Limonciello <superm1@kernel.org> wrote:
>>
>> On 7/8/2024 10:49, Bartosz Golaszewski wrote:
>>
>>>
>>> If you have CONFIG_OF enabled then of_platform_populate() will go the
>>> normal path and actually try to populate sub-nodes of the host bridge
>>> node. If there are no OF nodes (not a device-tree system) then it will
>>> fail.
>>>
>>> Bart
>>
>> So how about keep both patches then?
>
> No, it doesn't make sense. If CONFIG_OF is enabled then -ENODEV is a
> valid error. I was wrong to apply the previous patch as it would lead
> to hiding actual errors on OF-enabled systems.
>
> Bart
Got it; thanks.
next prev parent reply other threads:[~2024-07-08 16:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-07 18:38 [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled Bert Karwatzki
2024-07-07 18:47 ` Lukas Wunner
2024-07-08 0:37 ` Krzysztof Wilczyński
2024-07-08 6:52 ` Bartosz Golaszewski
2024-07-08 8:33 ` Krzysztof Wilczyński
2024-07-08 15:29 ` Mario Limonciello
2024-07-08 15:34 ` Bartosz Golaszewski
2024-07-08 15:44 ` Manivannan Sadhasivam
2024-07-08 15:46 ` Mario Limonciello
2024-07-08 15:49 ` Bartosz Golaszewski
2024-07-08 15:53 ` Mario Limonciello
2024-07-08 15:58 ` Bartosz Golaszewski
2024-07-08 16:01 ` Mario Limonciello [this message]
2024-07-08 15:58 ` Manivannan Sadhasivam
2024-07-08 7:22 ` Manivannan Sadhasivam
2024-07-08 9:54 ` Bartosz Golaszewski
2024-07-08 9:55 ` Bartosz Golaszewski
2024-07-08 19:13 ` Bjorn Helgaas
2024-07-08 19:16 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81a93b15-2791-4eec-8164-f141fae9a5f1@kernel.org \
--to=superm1@kernel.org \
--cc=PraveenKumar.Patil@amd.com \
--cc=amit.pundir@linaro.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=caleb.connolly@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=manivannan.sadhasivam@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=spasswolf@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox