From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Srikanth Thokala <sthokal@xilinx.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
svemula@xilinx.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
Grant Likely <grant.likely@linaro.org>,
anirudh@xilinx.com, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v5] pcie: Add Xilinx PCIe Host Bridge IP driver
Date: Mon, 28 Jul 2014 15:02:52 +0200 [thread overview]
Message-ID: <8258903.Rn4s07GKGV@wuerfel> (raw)
In-Reply-To: <CA+mB=1JhDF=BBXcyTbgVB8S7qH=Mb1JH78HLL4pA9OBH19hQvA@mail.gmail.com>
On Monday 28 July 2014 18:04:34 Srikanth Thokala wrote:
> Hi Arnd and Rob,
>
> I discussed with Bjorn and we believe this patch is in good shape to
> apply. And Bjorn requires ACKs to apply this patch. So, could you
> guys please review this patch and provided your ACKs to this patch.
Looks great for the most part. I've looked through the whole driver
again, and I have two small issues remaining:
a) Please clarify in the changeset description why there is no support
for PCI I/O space.
b) I think you should use the 'msi-parent' property, and the
of_pci_find_msi_chip_by_node() to find the msi_chip for the
PCI controller. This will make it possible to forward MSIs
to the main interrupt controller in the system, which is more
efficient. See the pcie-mvebu driver for an example of this.
Other than these:
Acked-by: Arnd Bergmann <arnd@arndb.de>
Arnd
next prev parent reply other threads:[~2014-07-28 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 16:03 [PATCH v5] pcie: Add Xilinx PCIe Host Bridge IP driver Srikanth Thokala
2014-07-28 12:34 ` Srikanth Thokala
2014-07-28 13:02 ` Arnd Bergmann [this message]
2014-07-30 11:24 ` Srikanth Thokala
2014-08-12 9:37 ` Michal Simek
2014-08-18 9:17 ` Srikanth Thokala
2014-08-18 18:49 ` Bjorn Helgaas
2014-08-20 12:13 ` Srikanth Thokala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8258903.Rn4s07GKGV@wuerfel \
--to=arnd@arndb.de \
--cc=anirudh@xilinx.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sthokal@xilinx.com \
--cc=svemula@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).