From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6627BC43217 for ; Mon, 21 Nov 2022 12:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231294AbiKUMAD (ORCPT ); Mon, 21 Nov 2022 07:00:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbiKUMAB (ORCPT ); Mon, 21 Nov 2022 07:00:01 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9434B848 for ; Mon, 21 Nov 2022 04:00:00 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id a15so14229410ljb.7 for ; Mon, 21 Nov 2022 04:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gAe96EUQJW/t2YfQOYFjoHjjiIW4hHrPPaKyPCc7BE4=; b=UVduBhk3PJQZkKzEskUrpKs00z1z4r/O7LnJCkT22HInQOeMTGaNIiUeqIGHvlHNel 8VqMPfMXtV6tMv9ea7G6sbKvzE3Fm/DlG1E+g8NcPhYe8kgMQ604qRLIDomYKgkO4nJm nNM0oOsRVkJDTr9ybiWyVEr8r6WawaItHr7qHt8Sbx4Ok3kdRHr2SR9GXJjMcjqAyue3 iOGkflLwOC1bOY41x6zbbYbq9oqoBTN30Z/aCEk3crJLxYULIxr+CRUxsV3WKHgXoVok yHMtfO5pYc15hhPs6wnzHYeNYaUln8nxRvBy6UGnsaaprdi+rLUUBCYXS1isltaJirK1 YmLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gAe96EUQJW/t2YfQOYFjoHjjiIW4hHrPPaKyPCc7BE4=; b=5EkUKp4hZNXQjq5obn5vHv3/3YBs+tJsNViFGdI8/173J4TYVZHnogWV452BUUPMZc GElIBZze5WrJL50TlF4phzzoyeKs2VVVftBLcJiSqNBi/h6sINQARWM75sD1o+V+mN9s zzH6sPVIlwctQTjZv2AL4zWlFvQ1dBGWmb0SuvpFzbzjBPCkvbUxHxaqsYDummdsLHDb u6SpvoDIK2F4L+US+r5GaeEXsWZGeCesUm11vJaOm80IFLHgkpKaSIQuE/uA8ttglUx9 kXny+IEixis3Aest0J8b38dJRWw5/Vs+//GtDrmaP9Qql9lfd9JNSvzhki+MmKbZdtIi FTVg== X-Gm-Message-State: ANoB5pmMrz9Cz/gXOllGPg/w2lZHilHrtHoOisvmWz4RAUF5EL7lGXnO nGMVo6c6e7OcWB6/3APyuRK53A== X-Google-Smtp-Source: AA0mqf6lo8pDgZCEf5cpGQ6TpOYX19afdgtwbFTqg3DuazhEzItnWlNNkGFC2exRFsAu0oB9C2ARJA== X-Received: by 2002:a05:651c:160f:b0:278:d847:1a8b with SMTP id f15-20020a05651c160f00b00278d8471a8bmr5107958ljq.17.1669031999150; Mon, 21 Nov 2022 03:59:59 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id p3-20020ac24ec3000000b00492e3a8366esm2005053lfr.9.2022.11.21.03.59.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 03:59:58 -0800 (PST) Message-ID: <856449f3-6341-78d8-28db-3d4b8a0a25ad@linaro.org> Date: Mon, 21 Nov 2022 12:59:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/6] dt-bindings: phy: Add PCIe PHY bindings for FSD Content-Language: en-US To: Shradha Todi , bhelgaas@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, kishon@ti.com, vkoul@kernel.org, lpieralisi@kernel.org, kw@linux.com, mani@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, alim.akhtar@samsung.com, ajaykumar.rs@samsung.com, rcsekar@samsung.com, sriranjani.p@samsung.com, bharat.uppal@samsung.com, s.prashar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, p.rajanbabu@samsung.com, niyas.ahmed@samsung.com, chanho61.park@samsung.com Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20221121105210.68596-1-shradha.t@samsung.com> <20221121105210.68596-2-shradha.t@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221121105210.68596-2-shradha.t@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 21/11/2022 11:52, Shradha Todi wrote: > Document the PCIe PHY device tree bindings for Tesla > FSD SoC Subject: drop second, redundant "bindings". > > Signed-off-by: Shradha Todi > --- > .../bindings/phy/phy-tesla-pcie.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-tesla-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/phy/phy-tesla-pcie.yaml b/Documentation/devicetree/bindings/phy/phy-tesla-pcie.yaml > new file mode 100644 > index 000000000000..8fa9a050af7a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-tesla-pcie.yaml Filename based on compatible. > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/phy-tesla-pcie.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tesla FSD SoC PCIe PHY > + > +maintainers: > + - Shradha Todi > + > +properties: > + "#phy-cells": > + const: 0 Put compatible as first. > + > + compatible: > + enum: > + - tesla,fsd-pcie-phy > + > + reg: > + minItems: 2 Drop minItems > + maxItems: 2 > + > + reg-names: > + minItems: 2 > + maxItems: 2 Drop both. > + items: > + enum: [phy, pcs] Instead list items one after another. > + description: | > + phy is the register access to PMA layer > + pcs is the register access to PCS layer These go to describing items in 'reg:' > + > + phy-mode: > + description: | > + Defines the bifurcation mode of the PHY enum, probably type as well... phy-mode is usually a string. Is it here? > + > + tesla,pmureg-phandle: Drop phandle, so tesla,pmu-syscon > + $ref: '/schemas/types.yaml#/definitions/phandle' Drop quotes > + description: phandle for PMU system controller interface used to > + control PMU register bits for PCIe PHY > + > + tesla,pcie-sysreg: > + $ref: '/schemas/types.yaml#/definitions/phandle' Drop quotes > + description: phandle for system control registers, used to > + control phy signals at system level > + > +required: > + - "#phy-cells" > + - compatible compatible first. > + - reg > + - reg-names > + - phy-mode > + - tesla,pmureg-phandle > + - tesla,pcie-sysreg > + > +additionalProperties: false > + > +examples: > + - | > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + pcie_phy0: pcie-phy@15080000 { > + compatible = "tesla,fsd-pcie-phy"; > + #phy-cells = <0>; > + reg = <0x0 0x15080000 0x0 0x2000>, <0x0 0x150A0000 0x0 0x1000>; > + reg-names = "phy", "pcs"; > + tesla,pmureg-phandle = <&pmu_system_controller>; > + tesla,pcie-sysreg = <&sysreg_fsys0>; > + phy-mode = <0>; > + status = "disabled"; Drop status > + }; > + }; > +... Best regards, Krzysztof