From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Robin Murphy <robin.murphy@arm.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jeffrey Hugo <jhugo@codeaurora.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Evan Green <evgreen@chromium.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Manu Gautam <mgautam@codeaurora.org>,
iommu <iommu@lists.linux-foundation.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v1 2/3] arm64: dts: qcom: msm8998: Add PCIe SMMU node
Date: Wed, 3 Apr 2019 14:56:05 +0530 [thread overview]
Message-ID: <868a3924-928c-ff23-e39f-8c521eec455a@codeaurora.org> (raw)
In-Reply-To: <e6d2200d-f6b9-3c27-f166-537742b32bfe@arm.com>
On 4/2/2019 7:24 PM, Robin Murphy wrote:
> On 30/03/2019 14:18, Vivek Gautam wrote:
>>> You should probably have some "bus" and "iface" clocks too, per the
>>> requirement of "qcom,smmu-v2". Maybe Vivek might know what's relevant
>>> for MSM8998?
>>
>> As Jeffrey rightly mentioned, these clocks are not under the control
>> of Linux.
>> So, we won't need to add clocks to this SMMU.
>
> OK, in that case the "clock-names" part of binding doc probably wants
> refining to reflect which implementations do actually require clocks.
Certainly.
Marc, do you want to push a patch for the same? Or, let me know I can
prepare one.
Thanks
Vivek
>
> Robin.
next prev parent reply other threads:[~2019-04-03 9:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 16:59 [PATCH v1 0/3] PCIe and AR8151 on APQ8098/MSM8998 Marc Gonzalez
2019-03-28 17:01 ` [PATCH v1 1/3] PCI: qcom: Setup PCIE20_PARF_BDF_TRANSLATE_N Marc Gonzalez
2019-04-02 8:08 ` Stanimir Varbanov
2019-04-02 10:44 ` Marc Gonzalez
2019-03-28 17:05 ` [PATCH v1 2/3] arm64: dts: qcom: msm8998: Add PCIe SMMU node Marc Gonzalez
2019-03-29 10:51 ` Marc Gonzalez
2019-03-29 18:29 ` Robin Murphy
2019-03-29 19:42 ` Jeffrey Hugo
2019-03-30 14:18 ` Vivek Gautam
2019-04-02 13:54 ` Robin Murphy
2019-04-03 9:26 ` Vivek Gautam [this message]
2019-03-28 17:06 ` [PATCH v1 3/3] arm64: dts: qcom: msm8998: Add PCIe PHY and RC nodes Marc Gonzalez
2019-04-04 10:01 ` Marc Gonzalez
2019-04-10 15:32 ` Stanimir Varbanov
2019-04-11 8:44 ` Marc Gonzalez
2019-04-11 9:09 ` Stanimir Varbanov
2019-04-11 9:38 ` Marc Gonzalez
2019-06-11 15:55 ` [PATCH v1 0/3] PCIe and AR8151 on APQ8098/MSM8998 Lorenzo Pieralisi
2019-06-11 16:30 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868a3924-928c-ff23-e39f-8c521eec455a@codeaurora.org \
--to=vivek.gautam@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).