From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAE6F28DC0; Mon, 1 Apr 2024 12:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711974565; cv=none; b=FaIU6K9Q1H5pX4gg3eo5uQYkLoDN4EVxeYzdplS04+7z8DMvRHV+vj38eJ6fgg3qj0qZEhs2dsGU6F1/Iiq/JDdmQ3k9W0btryK46Ku41AjRGyoKBzSQAEh6nnpEF7AkEkfeV//oi1gswXzBdeWCwqidD4VnEulDytrcIHDfRUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711974565; c=relaxed/simple; bh=/lno/zNuFJUkiI9tjcPHieb/7O+EZVgn1eYYWFHqDoc=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=I8DImKzXXXe2p/cxoXY675aBh4hg7ztpVq09RCBmJ+rTizGKtCRo0JK7K+QSSGaMYIDqoIS1RTbdQllF3gHH6Uz0SkfQTUiWrMUrJpysTBdRTOeOxNcOE00Q2ZtL676Z4x+pRkJz5PCb6PIeQp3uBgxgbXgJYmRyTpsZLrWwzcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jcLuJt8c; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jcLuJt8c" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48B57C433F1; Mon, 1 Apr 2024 12:29:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711974565; bh=/lno/zNuFJUkiI9tjcPHieb/7O+EZVgn1eYYWFHqDoc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jcLuJt8cngb2q3ByjzN8cGT0gbcR0iJy32xXlYRiZeIM4VnDMk/qS4pBV9XWJ5du3 mthMb77GODRmEemhaGAzC8HVQQGnvpy2VZXvNHF/dnth5gynh/Q2ftU2EJSXHz3k5/ 3j+vb5tWuAORfc+KaMEJuK9zc+sTWjlmmQTG+TLvFCXA6T4xmZc76fPZ7YNkhyo9pH x0R6lRgNRvskPJNRus+94+Mh45x7+eBgCiGntOx8xm8Chtrddsv8ZrRsEX6AA3ml6z YD7c0MFSbDV3fSClfU11wIaiRBraQIXPKBwJXB5konzL4O7NoRRKGRXRYOvUZCeemw b86tVagh5IDKQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rrGmx-000HyG-5T; Mon, 01 Apr 2024 13:29:23 +0100 Date: Mon, 01 Apr 2024 13:29:22 +0100 Message-ID: <86cyr9z2ot.wl-maz@kernel.org> From: Marc Zyngier To: "Arnd Bergmann" Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "Lorenzo Pieralisi" , Krzysztof =?UTF-8?B?V2lsY3p5?= =?UTF-8?B?xYRza2k=?= , "Rob Herring" , "Bjorn Helgaas" Subject: Re: [PATCH] PCI: apple: Fix dependency on 16kB pages In-Reply-To: <3c9523b7-9bba-4fe2-97a1-893e8505e054@app.fastmail.com> References: <20240401121933.600977-1-maz@kernel.org> <3c9523b7-9bba-4fe2-97a1-893e8505e054@app.fastmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: arnd@arndb.de, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 01 Apr 2024 13:23:27 +0100, "Arnd Bergmann" wrote: >=20 > On Mon, Apr 1, 2024, at 14:19, Marc Zyngier wrote: > > While d3e5bab923d3 consolidated the various definitions for page sizes, > > it ended up breaking the Apple PCIe driver, which still depends on > > ARM64_PAGE_SHIFT. Switch over to HAVE_PAGE_SIZE_16KB to make the driver > > selectable again. > > > > Cc: Arnd Bergmann > > Cc: Lorenzo Pieralisi > > Cc: "Krzysztof Wilczy=C5=84ski" > > Cc: Rob Herring > > Cc: Bjorn Helgaas > > Fixes: d3e5bab923d3 ("arch: simplify architecture specific page size=20 > > configuration") > > Signed-off-by: Marc Zyngier >=20 > The dependency only exists in the asahi kernel with commit > db5709e83c11 ("PCI: apple: Add depends on ARM64_PAGE_SHIFT =3D 14") > and is not present upstream. You are absolutely right, and I should have checked where this dependency was coming from. Apologies for the noise. M. --=20 Without deviation from the norm, progress is not possible.