From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C934470810; Tue, 1 Jul 2025 10:54:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751367253; cv=none; b=fuljt/5QN3BUBMGOEmLhk6rwpN/n8bGKDGg9pUQQJq1UJRYiPvjTvxhX1W68qje3sNXvC4RPpcnvyLcYfapoIFbGETgAFikZqDXkoZa9nboVc67yRh9meym3XZlQk141nQ8pDgLrsFLkrnNUtreXRAcyMx4itZg6HXreSItr17U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751367253; c=relaxed/simple; bh=pmrJ52f7KLRWP+Kzra4zThVHSaWjAGKLunXQ+85Io84=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=J7CyIc1L/XMKSLbmBVdO7ApZwSv3C6Qpax5uW/B6h4xc+sRbpi0Iz8ks3mY9nqefC3QBNNpsSRM23EMKhsG/c9nKVgHRQmVeToEsg7Qe8OONyGZqYndKlKYE8Hv2oVpz7xK52LRbytDGy0Zw20I7AVndBWowGxIXm2jtaTrsA38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pQTwJ004; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pQTwJ004" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 437E3C4CEEB; Tue, 1 Jul 2025 10:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751367253; bh=pmrJ52f7KLRWP+Kzra4zThVHSaWjAGKLunXQ+85Io84=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pQTwJ0045Ii+RA2IgfwYQBiGhTcE5N41waq6Icbsi90XxoGctw76d4BC1V4aRszpJ Oap+MWQkrRszzrvRCdvVCIQlh82yA8mhGnn1MnT3ZJETh2TEE9MYSvKN41u6sjQmds p0dbqlFGLT6UIDdUfnV3qs+EbMzHLfJmqn7T8K5ABtSW8aLBwIuEB2QlqkfYzEDq9+ MTtLsPTBacD+P0o4DrQKrqDyn8Xr3gK/yW+DKNTBTN7WXtPKxUZDBKERTNu2iaByRr 01gZCj7LLx0J0cQxwM97iqi/y4upQp2wMQqcsEa4molLGg4bMDxqLKr20Ghk3lKYVS 4F7dSxj7eCBgA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uWYct-00BWpQ-1P; Tue, 01 Jul 2025 11:54:11 +0100 Date: Tue, 01 Jul 2025 11:54:10 +0100 Message-ID: <86frfgb2r1.wl-maz@kernel.org> From: Marc Zyngier To: Bjorn Helgaas Cc: Bjorn Helgaas , Alyssa Rosenzweig , Rob Herring , Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Janne Grunau , Geert Uytterhoeven , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] PCI: host-generic: Fix driver_data overwriting bugs In-Reply-To: <20250630173415.GA1787642@bhelgaas> References: <86ikkdb0uj.wl-maz@kernel.org> <20250630173415.GA1787642@bhelgaas> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: helgaas@kernel.org, bhelgaas@google.com, alyssa@rosenzweig.io, robh@kernel.org, mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, j@jannau.net, geert+renesas@glider.be, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 30 Jun 2025 18:34:15 +0100, Bjorn Helgaas wrote: > > On Mon, Jun 30, 2025 at 06:23:00PM +0100, Marc Zyngier wrote: > > On Mon, 30 Jun 2025 18:06:01 +0100, > > Bjorn Helgaas wrote: > > > > > > On Wed, Jun 25, 2025 at 12:18:03PM +0100, Marc Zyngier wrote: > > > > Geert reports that some drivers do rely on the device driver_data > > > > field containing a pointer to the bridge structure at the point of > > > > initialising the root port, while this has been recently changed to > > > > contain some other data for the benefit of the Apple PCIe driver. > > > > > > > > This small series builds on top of Geert previously posted (and > > > > included as a prefix for reference) fix for the Microchip driver, > > > > which breaks the Apple driver. This is basically swapping a regression > > > > for another, which isn't a massive deal at this stage, as the > > > > follow-up patch fixes things for the Apple driver by adding extra > > > > tracking. > > > > > > Is there a bisection hole between patches 1 and 2? > > > > > > 1: PCI: host-generic: Set driver_data before calling gen_pci_init() > > > 2: PCI: apple: Add tracking of probed root ports > > > > > > If so, would it be practical to avoid the hole by reordering those > > > patches? > > > > Sure, but you said you already had queued patch #1, and what is in > > -rc1 already breaks Geert's box. So no matter the order, we break > > something at some point. > > I did, but when I saw your problem report and subsequent updates, I > put Geert's patch on hold. > > > If you want to only break one thing, then yes, swapping these two > > patches is the correct thing to do. > > I swapped them and put them back on pci/for-linus for v6.16: > > https://git.kernel.org/cgit/linux/kernel/git/pci/pci.git/log/?h=for-linus&id=ba74278c638d > LGTM, thanks for picking these up! M. -- Without deviation from the norm, progress is not possible.