From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC63C25B4E for ; Sun, 22 Jan 2023 10:47:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbjAVKr0 (ORCPT ); Sun, 22 Jan 2023 05:47:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbjAVKr0 (ORCPT ); Sun, 22 Jan 2023 05:47:26 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E2AC13500; Sun, 22 Jan 2023 02:47:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 07B6660BC5; Sun, 22 Jan 2023 10:47:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59610C433EF; Sun, 22 Jan 2023 10:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674384444; bh=qOi/1Aqwa2JrdVvobn/vFD9TgB5xq1PG7dJtowJf2C0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=B4nNX53dDuo4U+hzDxPjlFuvEq0hmZSf8x9ecggu678w231t/jH/C0S6xgtdeJPco C/ZpbtMZ5wR4DkFVv5rSRAKWw9Wf748d0PeKvbytE6zfW3zk85+HJAPv4gJAjSwGdr b5AGXTrqZsT1dOa/rUfPOrpqcNtv3z1Zbl6oC/N39+Di3eIIfBGkesuhoiBWJQSLbH k2OXRLaiw0GZ3KtDKztztbMjFTMwZSZKoAwVxJ9V0vvf0plr0zfgKw8l1M366uXCQT F7jPkaG4vMaD8FDaNW5S9V/cQIadBtjS/q/SYNQQeqG8yH1j30JDmmdY9M9TvmAJDn 2hLd/6z1qo91A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pJXsf-003kAw-Si; Sun, 22 Jan 2023 10:47:22 +0000 Date: Sun, 22 Jan 2023 10:47:21 +0000 Message-ID: <86h6win8w6.wl-maz@kernel.org> From: Marc Zyngier To: Lizhe Cc: bhelgaas@google.com, tglx@linutronix.de, darwi@linutronix.de, jgg@ziepe.ca, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] drivers/msi.c : use devm_ioremap replace ioremap In-Reply-To: <20230121170420.8681-1-sensor1010@163.com> References: <20230121170420.8681-1-sensor1010@163.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sensor1010@163.com, bhelgaas@google.com, tglx@linutronix.de, darwi@linutronix.de, jgg@ziepe.ca, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, 21 Jan 2023 17:04:20 +0000, Lizhe wrote: > > use devm_ioremap replace ioremap > > Signed-off-by: Lizhe > --- > drivers/pci/msi/msi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c > index 1f716624ca56..184eca85b88b 100644 > --- a/drivers/pci/msi/msi.c > +++ b/drivers/pci/msi/msi.c > @@ -566,7 +566,7 @@ static void __iomem *msix_map_region(struct pci_dev *dev, > table_offset &= PCI_MSIX_TABLE_OFFSET; > phys_addr = pci_resource_start(dev, bir) + table_offset; > > - return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE); > + return devm_ioremap(&dev->dev, phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE); > } And where is the unmap dealt with? From what I can see, this will probably explode when the device is removed... M. -- Without deviation from the norm, progress is not possible.