From: Marc Zyngier <maz@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "Toan Le" <toan@os.amperecomputing.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()
Date: Tue, 05 Aug 2025 08:51:40 +0100 [thread overview]
Message-ID: <86ms8e6wab.wl-maz@kernel.org> (raw)
In-Reply-To: <aIzCbVd93ivPinne@stanley.mountain>
On Fri, 01 Aug 2025 14:34:37 +0100,
Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> There is a typo so we accidentally return positive EINVAL instead of
> negative -EINVAL. Add the missing '-' character.
>
> Fixes: 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/pci/controller/pci-xgene-msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
> index 0a37a3f1809c..654639bccd10 100644
> --- a/drivers/pci/controller/pci-xgene-msi.c
> +++ b/drivers/pci/controller/pci-xgene-msi.c
> @@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
> msi_val = xgene_msi_int_read(xgene_msi, i);
> if (msi_val) {
> dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
> - return EINVAL;
> + return -EINVAL;
> }
>
> irq = platform_get_irq(pdev, i);
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-08-05 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 13:34 [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup() Dan Carpenter
2025-08-05 7:51 ` Marc Zyngier [this message]
2025-08-11 11:02 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ms8e6wab.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=toan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).