From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C16E8946C; Tue, 5 Aug 2025 07:51:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380303; cv=none; b=oujEKI8NKG2VgRjGT6xljzLHBrEaBBKmy6eogqtc2XR8flvkuDnuqFOMr17PxZMuBK5pQlQm1tSaXh63nXvjdJz1kNovpQwGIrI42Pz5sFIc3QzB6csTbTeNVuJ6JWkhqWu55J1tvqe5rDErg6Bivbt2mD9clEF8txpNpe6oZKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380303; c=relaxed/simple; bh=lm9nuCGGx4gMCOnD7VP8r/yEfF12fwCxH+nmwdEZo2Y=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=FIbRrV+wZDR4c9KRtSibdprJWB07SA3p8wVaG+vDuQMUMb0/E/soHzC2NUi4rVI3rDEcE1roPB9SgLIflNdul9gFglakjbofcHR58d76kT6vzmydI1R19N9BQtXcpmAq9aZPY74AxTyt7uqgvyd59kbf7BasM2Xi3NgNSOMxRNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V/wTo+7e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V/wTo+7e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FD9CC4CEF4; Tue, 5 Aug 2025 07:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754380303; bh=lm9nuCGGx4gMCOnD7VP8r/yEfF12fwCxH+nmwdEZo2Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V/wTo+7eKfeslKF9rfcaUrhfVqZsjAmicnMmyfiquzuhnD5ABG0bsDEyWVsBVlp0k v3ilyTYzMw7AkqzrghRguerGHnfavIHs6gnZiwPEHMIScnoS2b6eiIMFCXhECNPAu/ /ymxRWYBaFRvWE4rjVcxoLzjtFUWeFLaPd3NVqMAGqbqOtwPi2ZUfKodrYsuYJwgR1 yXseT+oSL0yLj+T8tkIYWjr8AVO1lzoOmsCwXMYydxLM2jV0Tt7vD78GYY9TCOidw8 cBQO9H5ZWlqpQy6n05qjzp7cQnqzXePMoljj1H5RMaimD3tI3u/SOsG0SF587MzREB np1WL2neozi8A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ujCST-00437m-3a; Tue, 05 Aug 2025 08:51:41 +0100 Date: Tue, 05 Aug 2025 08:51:40 +0100 Message-ID: <86ms8e6wab.wl-maz@kernel.org> From: Marc Zyngier To: Dan Carpenter Cc: Toan Le , Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup() In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dan.carpenter@linaro.org, toan@os.amperecomputing.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 01 Aug 2025 14:34:37 +0100, Dan Carpenter wrote: > > There is a typo so we accidentally return positive EINVAL instead of > negative -EINVAL. Add the missing '-' character. > > Fixes: 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown") > Signed-off-by: Dan Carpenter > --- > drivers/pci/controller/pci-xgene-msi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c > index 0a37a3f1809c..654639bccd10 100644 > --- a/drivers/pci/controller/pci-xgene-msi.c > +++ b/drivers/pci/controller/pci-xgene-msi.c > @@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev) > msi_val = xgene_msi_int_read(xgene_msi, i); > if (msi_val) { > dev_err(&pdev->dev, "Failed to clear spurious IRQ\n"); > - return EINVAL; > + return -EINVAL; > } > > irq = platform_get_irq(pdev, i); Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.