* [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()
@ 2025-08-01 13:34 Dan Carpenter
2025-08-05 7:51 ` Marc Zyngier
2025-08-11 11:02 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-08-01 13:34 UTC (permalink / raw)
To: Marc Zyngier
Cc: Toan Le, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, linux-pci,
linux-arm-kernel, linux-kernel, kernel-janitors
There is a typo so we accidentally return positive EINVAL instead of
negative -EINVAL. Add the missing '-' character.
Fixes: 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/pci/controller/pci-xgene-msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
index 0a37a3f1809c..654639bccd10 100644
--- a/drivers/pci/controller/pci-xgene-msi.c
+++ b/drivers/pci/controller/pci-xgene-msi.c
@@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
msi_val = xgene_msi_int_read(xgene_msi, i);
if (msi_val) {
dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
- return EINVAL;
+ return -EINVAL;
}
irq = platform_get_irq(pdev, i);
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()
2025-08-01 13:34 [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup() Dan Carpenter
@ 2025-08-05 7:51 ` Marc Zyngier
2025-08-11 11:02 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2025-08-05 7:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Toan Le, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, linux-pci,
linux-arm-kernel, linux-kernel, kernel-janitors
On Fri, 01 Aug 2025 14:34:37 +0100,
Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> There is a typo so we accidentally return positive EINVAL instead of
> negative -EINVAL. Add the missing '-' character.
>
> Fixes: 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/pci/controller/pci-xgene-msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
> index 0a37a3f1809c..654639bccd10 100644
> --- a/drivers/pci/controller/pci-xgene-msi.c
> +++ b/drivers/pci/controller/pci-xgene-msi.c
> @@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
> msi_val = xgene_msi_int_read(xgene_msi, i);
> if (msi_val) {
> dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
> - return EINVAL;
> + return -EINVAL;
> }
>
> irq = platform_get_irq(pdev, i);
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()
2025-08-01 13:34 [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup() Dan Carpenter
2025-08-05 7:51 ` Marc Zyngier
@ 2025-08-11 11:02 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2025-08-11 11:02 UTC (permalink / raw)
To: Marc Zyngier, Dan Carpenter
Cc: Toan Le, Lorenzo Pieralisi, Krzysztof Wilczyński,
Rob Herring, Bjorn Helgaas, linux-pci, linux-arm-kernel,
linux-kernel, kernel-janitors
On Fri, 01 Aug 2025 16:34:37 +0300, Dan Carpenter wrote:
> There is a typo so we accidentally return positive EINVAL instead of
> negative -EINVAL. Add the missing '-' character.
>
>
Applied, thanks!
[1/1] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()
commit: b26fc701a25195134ff0327709a0421767c4c7b2
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-11 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-01 13:34 [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup() Dan Carpenter
2025-08-05 7:51 ` Marc Zyngier
2025-08-11 11:02 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).