From: Marc Zyngier <maz@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Johan Hovold" <johan@kernel.org>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Pali Rohár" <pali@kernel.org>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Xiaowei Song" <songxiaowei@hisilicon.com>,
"Binghui Wang" <wangbinghui@hisilicon.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
linux-pci@vger.kernel.org, "Krzysztof Wilczyński" <kw@linux.com>,
"Ley Foon Tan" <ley.foon.tan@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: Why set .suppress_bind_attrs even though .remove() implemented?
Date: Thu, 17 Oct 2024 10:56:29 +0100 [thread overview]
Message-ID: <86o73j3vea.wl-maz@kernel.org> (raw)
In-Reply-To: <20241017093040.k6pefhmfdmw4nicz@thinkpad>
On Thu, 17 Oct 2024 10:30:40 +0100,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
>
> On Thu, Oct 17, 2024 at 09:48:50AM +0100, Marc Zyngier wrote:
> > On Thu, 17 Oct 2024 09:25:26 +0100,
> > Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
> > >
> > > On Thu, Oct 17, 2024 at 08:50:11AM +0100, Marc Zyngier wrote:
> > > > On Thu, 17 Oct 2024 06:23:35 +0100,
> > > > Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
> > > > >
> > > > > So can we proceed with the series making Qcom driver modular?
> > > >
> > > > Who is volunteering to fix the drivers that will invariably explode
> > > > once we allow this?
> > > >
> > >
> > > Why should anyone volunteer first up? If the issue gets reported for a driver
> > > blowing up, then the driver has to be fixed by the maintainer or someone, just
> > > like any other bug.
> >
> > You are introducing a new behaviour, and decide that it is fair game
> > to delegate the problems *you* introduced to someone else?
> >
>
> You are getting it completely wrong. I'm not delegating any issues. If the so
> called *new* behavior in the controller driver uncovers the bug in a client
> driver, then that is not called *delegating*.
>
> > Maybe you should reconsider what it means to be a *responsible*
> > maintainer.
> >
>
> Sure, by not providing a development option useful to the users envisioning
> issues that may not happen at all.
>
> Even if any issue reported for the platform I'm maintaining, I am willing to put
> in the efforts to fix them.
>
> > > From reading the thread, the major concern was disposing the IRQs before
> > > removing the domain and that is now taken care of. If you are worrying about a
> > > specific issue, please say so.
> >
> > That concern still exists, and I haven't seen a *consistent* approach
> > encompassing all of the PCI controllers. What I've seen is a bunch of
> > point hacks addressing a local issue on a particular implementation.
> >
>
> Again, please be specific about your concern so that someone could try to
> address them. Right now all I'm hearing is, "hey don't do this, else
> something may blow up".
You know what? Have it your way. After all, this sort of behaviour is
exactly why I stopped dealing with this subsystem.
>
> > I don't think that's the correct approach, but hey, what do I
> > understand about interrupts and kernel maintenance?
> >
>
> I'd like to quote the message in your signature here: "Without deviation from
> the norm, progress is not possible".
You should look up who wrote this, and appreciate *why* they wrote it,
and what they meant by that. That should put some of the above in
perspective.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2024-10-17 9:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 19:54 Why set .suppress_bind_attrs even though .remove() implemented? Bjorn Helgaas
2022-07-21 20:46 ` Pali Rohár
2022-07-21 20:48 ` Conor.Dooley
2022-07-21 22:21 ` Bjorn Helgaas
2022-07-21 22:48 ` Pali Rohár
2022-07-22 13:26 ` Johan Hovold
2022-07-22 14:38 ` Bjorn Helgaas
2022-07-25 13:25 ` Johan Hovold
2022-07-25 14:43 ` Marc Zyngier
2022-07-25 15:18 ` Johan Hovold
2022-07-25 17:35 ` Marc Zyngier
2022-07-26 9:56 ` Johan Hovold
2022-07-27 19:57 ` Bjorn Helgaas
2022-07-28 12:17 ` Johan Hovold
2024-10-17 5:23 ` Manivannan Sadhasivam
2024-10-17 7:50 ` Marc Zyngier
2024-10-17 8:25 ` Manivannan Sadhasivam
2024-10-17 8:48 ` Marc Zyngier
2024-10-17 9:30 ` Manivannan Sadhasivam
2024-10-17 9:56 ` Marc Zyngier [this message]
2022-09-27 15:27 ` Lorenzo Pieralisi
2022-09-28 6:36 ` Johan Hovold
2022-07-22 14:39 ` Bjorn Helgaas
2022-07-22 17:06 ` Marc Zyngier
2022-07-22 17:17 ` Bjorn Helgaas
2022-07-24 9:38 ` Marc Zyngier
2022-07-25 20:18 ` Florian Fainelli
2022-07-25 17:49 ` Conor.Dooley
2022-07-26 7:26 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o73j3vea.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=helgaas@kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=pali@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=songxiaowei@hisilicon.com \
--cc=thierry.reding@gmail.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).