From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A5B6154454; Thu, 17 Oct 2024 08:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729154934; cv=none; b=pqpsFl+vcepzNCR12Ybs85KMKCqNL/RyCOtvLw1gr0KLILG/aWlHApumy9C01Cli6fc9gQuHJzwjdmBs8CPv0fIZAe8Mc1vjxXhybXaCdBCtbKlUxV3gq0n9VEdTzXD2saITHr2Y2LjTcddi4drQpb5yqEy9ZJwHXzya8FFCN9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729154934; c=relaxed/simple; bh=PJyxRc6nxDx4VlnALY+M8iW9wjUH/fxDQdCVMXnvySI=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ht7kaCCvH3MlX/1vPz3QkehXMO/F0t67OGorMW8YbYMrRYeMamMPpj+VZaIaRq9MyPQnT10EFRYl2wD8MhBV9mmbmofCrFL6zwVu4iAco0Owuwtz5EBWoBR0YpYzRz83gh58zBjHjaDEX45Ars1LpekCC9iyNpYgHlIRKnOLAck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HkBEW1IQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HkBEW1IQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A11C9C4CEC3; Thu, 17 Oct 2024 08:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729154933; bh=PJyxRc6nxDx4VlnALY+M8iW9wjUH/fxDQdCVMXnvySI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HkBEW1IQV53k6BL/MW0bE/vNcPz9rjlzgbXvTD5c+n53jVWn3RfJtw1EXnOoTosJw pl/DQVzMc/9EhIqipqCHDIzUmERC07BsFf2KM3tRzdpaoI0FtNe/FOC848zBh9uaNh dPBLRC46j+VxossSE7Nwu0ijJ7yJgdmDv5EWDXIlqdd2D9r04+pjHiuK0by+hjK4HU xs972LukBvjTPFoT7HHxVktCSq1SbROKPJTBU+q/cwC+IPwBgt20H8DAJDEmf7ygh2 3/z1R8cGjjsEWbrOUiLu5zmjUncsoidQOK7GRtGjKSQNSyhKyXVLMZ5KLjtf3vAqhW GwGmpxBteMmnA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t1MBf-004NY8-Ds; Thu, 17 Oct 2024 09:48:51 +0100 Date: Thu, 17 Oct 2024 09:48:50 +0100 Message-ID: <86r08f3yj1.wl-maz@kernel.org> From: Marc Zyngier To: Manivannan Sadhasivam Cc: Johan Hovold , Bjorn Helgaas , Pali =?UTF-8?B?Um9ow6Fy?= , Johan Hovold , Kishon Vijay Abraham I , Xiaowei Song , Binghui Wang , Thierry Reding , Ryder Lee , Jianjun Wang , linux-pci@vger.kernel.org, Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Ley Foon Tan , linux-kernel@vger.kernel.org Subject: Re: Why set .suppress_bind_attrs even though .remove() implemented? In-Reply-To: <20241017082526.ppoz7ynxas5nlht5@thinkpad> References: <20220727195716.GA220011@bhelgaas> <20241017052335.iue4jhvk5q4efigv@thinkpad> <86v7xr418s.wl-maz@kernel.org> <20241017082526.ppoz7ynxas5nlht5@thinkpad> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: manivannan.sadhasivam@linaro.org, johan@kernel.org, helgaas@kernel.org, pali@kernel.org, johan+linaro@kernel.org, kishon@ti.com, songxiaowei@hisilicon.com, wangbinghui@hisilicon.com, thierry.reding@gmail.com, ryder.lee@mediatek.com, jianjun.wang@mediatek.com, linux-pci@vger.kernel.org, kw@linux.com, ley.foon.tan@intel.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 17 Oct 2024 09:25:26 +0100, Manivannan Sadhasivam wrote: > > On Thu, Oct 17, 2024 at 08:50:11AM +0100, Marc Zyngier wrote: > > On Thu, 17 Oct 2024 06:23:35 +0100, > > Manivannan Sadhasivam wrote: > > > > > > So can we proceed with the series making Qcom driver modular? > > > > Who is volunteering to fix the drivers that will invariably explode > > once we allow this? > > > > Why should anyone volunteer first up? If the issue gets reported for a driver > blowing up, then the driver has to be fixed by the maintainer or someone, just > like any other bug. You are introducing a new behaviour, and decide that it is fair game to delegate the problems *you* introduced to someone else? Maybe you should reconsider what it means to be a *responsible* maintainer. > From reading the thread, the major concern was disposing the IRQs before > removing the domain and that is now taken care of. If you are worrying about a > specific issue, please say so. That concern still exists, and I haven't seen a *consistent* approach encompassing all of the PCI controllers. What I've seen is a bunch of point hacks addressing a local issue on a particular implementation. I don't think that's the correct approach, but hey, what do I understand about interrupts and kernel maintenance? > > As a Qcom PCIe driver maintainer, I'd like to provide users/developers the > flexibility to remove the driver for development purposes. Sure, whatever. M. -- Without deviation from the norm, progress is not possible.