From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB27E1E2312; Mon, 7 Jul 2025 15:58:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751903912; cv=none; b=R49vpK5DH6g4CWn73fBltSJhd386Jwt7SGFluLLMkm5m95HSX0B5Q1RzYLnNSRBmL860dj2Og/5EmESKCaYkDu0nVdlthwSYI58641sU8JZyI8By42WZnZwac6YfkUu0hdjoXPFfvGX5Tze1hhjK8awQqtZ7cn89AIepbLVcV8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751903912; c=relaxed/simple; bh=P4irvB71K+2W4L3UZ4XfcIYhsGHoRRAgpPJO3up2rls=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=AIpmttsEDML9+lnQ8Q8oh7o1U10vjzYBRSAGDwuImi/I9t5mbBrxTby1PplzAKznEjHBLtolqrStC7zG/MxTPcOL5ABucW9ZmsXtQckXBZuSRD1WYrXbCLIw1azr21O+ZsnQB/v7UadVq6eAYCZXZ+S0VgWAc86DjZ6Yu0/ClPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rp+rdsGq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rp+rdsGq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42707C4CEE3; Mon, 7 Jul 2025 15:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751903912; bh=P4irvB71K+2W4L3UZ4XfcIYhsGHoRRAgpPJO3up2rls=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rp+rdsGq/vMHLR9KSjygQYEnG6ZRxsoK+IGpmqfu42uwLxUD+Jvhbub/p4S9wwsXD GqDOc3Xp7OejMwTqYQAWHTTtrF8DcmUrDgeT7ZJRw0Z1DQdT3Hd3cWaPx8hEZLFIra 5bITNkQs3UybNuLapWcVRJAlLQOG4J506gIkKrLHWY8VixVeZeBDWVQ7RgtkpL+kRD iS+/+14qF+Efwo9fDql6v3y+yo6MWi2pQnW6IV7va2/Rr9nzfQE2o6AKmkZqOpRN/T NyAhOy39hs+n4Y6R5+fdAcHonIr00GfFcomCotVWmBiiOIi4UIqAERM1xmJeW2/p9Q mo55NETWfR/jw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uYoEg-00DSeu-3k; Mon, 07 Jul 2025 16:58:30 +0100 Date: Mon, 07 Jul 2025 16:58:29 +0100 Message-ID: <86v7o49emy.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Toan Le , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Thomas Gleixner Subject: Re: [PATCH 12/12] PCI: xgene-msi: Restructure handler setup/teardown In-Reply-To: References: <20250628173005.445013-1-maz@kernel.org> <20250628173005.445013-13-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, toan@os.amperecomputing.com, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 07 Jul 2025 12:14:09 +0100, Lorenzo Pieralisi wrote: > > On Sat, Jun 28, 2025 at 06:30:05PM +0100, Marc Zyngier wrote: > > Another utterly pointless aspect of the xgene-msi driver is that > > it is built around CPU hotplug. Which is quite amusing since this > > is one of the few arm64 platforms that, by construction, cannot > > do CPU hotplug in a supported way (no EL3, no PSCI, no luck). > > > > Drop the CPU hotplug nonsense and just setup the IRQs and handlers > > in a less overdesigned way, grouping things more logically in the > > process. > > > > Signed-off-by: Marc Zyngier > > --- > > drivers/pci/controller/pci-xgene-msi.c | 109 +++++++++---------------- > > 1 file changed, 37 insertions(+), 72 deletions(-) > > > > diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c > > index a22a6df7808c7..9f05c2a12da94 100644 > > --- a/drivers/pci/controller/pci-xgene-msi.c > > +++ b/drivers/pci/controller/pci-xgene-msi.c > > @@ -216,12 +216,6 @@ static int xgene_allocate_domains(struct device_node *node, > > return msi->inner_domain ? 0 : -ENOMEM; > > } > > > > -static void xgene_free_domains(struct xgene_msi *msi) > > -{ > > - if (msi->inner_domain) > > - irq_domain_remove(msi->inner_domain); > > -} > > - > > static int xgene_msi_init_allocator(struct device *dev) > > { > > xgene_msi_ctrl->bitmap = devm_bitmap_zalloc(dev, NR_MSI_VEC, GFP_KERNEL); > > @@ -271,26 +265,48 @@ static void xgene_msi_isr(struct irq_desc *desc) > > chained_irq_exit(chip, desc); > > } > > > > -static enum cpuhp_state pci_xgene_online; > > - > > static void xgene_msi_remove(struct platform_device *pdev) > > { > > - struct xgene_msi *msi = platform_get_drvdata(pdev); > > - > > - if (pci_xgene_online) > > - cpuhp_remove_state(pci_xgene_online); > > - cpuhp_remove_state(CPUHP_PCI_XGENE_DEAD); > > No question on the patch - just noticed we could remove > CPUHP_PCI_XGENE_DEAD from cpuhp_state since it would become > unused AFAICS. Good point. I'll add that to the queue. Thanks, M. -- Without deviation from the norm, progress is not possible.