Re: [PATCH] PCI: armada8k: add support for gpio controlled reset signal

[Baruch Siach <baruch@tkos.co.il>]

Hi Thomas,

As the listed maintainer of this driver, can you review this patch? This
patch makes the PCIe slot reset sequence independent from the
bootloader.

Thanks,
baruch

Lorenzo Pieralisi writes:
> On Wed, Oct 03, 2018 at 04:35:43PM +0300, Baruch Siach wrote:
>> On Wed, Oct 03, 2018 at 03:28:11PM +0200, Andrew Lunn wrote:
>> > On Wed, Oct 03, 2018 at 03:49:43PM +0300, Baruch Siach wrote:
>> > > This commit adds support for the gpio reset signal binding as described
>> > > in the designware-pcie.txt DT binding document. Both the documented
>> > > 'reset-gpio' property name, and the more standard 'reset-gpios' name are
>> > > supported.
>> >
>> > I don't know this code at all, so maybe a dumb question. Why support
>> > the old none-standard binding of reset-gpio on new hardware? I'm
>> > assuming reset-gpio is marked a deprecated and reset-gpios is
>> > recommended?
>>
>> This is all hidden behind the devm_gpiod_get_optional() call that only sees
>> the "reset" string. The generic code supports both the new property name and
>> also the older one for backward compatibility. This patch changes nothing in
>> this regard.
>>
>> The designware-pcie.txt document mentions the older 'reset-gpio' name. So I
>> mentioned that name as well in the commit log.
>
> I need Thomas' ACK to proceed with this patch.
>
> Thanks,
> Lorenzo

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -