From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9A1C43441 for ; Wed, 21 Nov 2018 07:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FD362145D for ; Wed, 21 Nov 2018 07:09:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FD362145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-pci-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726016AbeKURnH (ORCPT ); Wed, 21 Nov 2018 12:43:07 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:48727 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbeKURnG (ORCPT ); Wed, 21 Nov 2018 12:43:06 -0500 Received: from tarshish (unknown [10.0.8.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 34CA544042B; Wed, 21 Nov 2018 09:09:47 +0200 (IST) References: <405efb21a4600efad10413fcf4c72aacce180125.1538570983.git.baruch@tkos.co.il> <20181003132811.GC427@lunn.ch> <20181003133543.t7laclm5wbj2olhq@sapphire.tkos.co.il> <20181116121043.GC3228@e107981-ln.cambridge.arm.com> User-agent: mu4e 1.0; emacs 25.2.2 From: Baruch Siach To: Thomas Petazzoni Cc: Lorenzo Pieralisi , Andrew Lunn , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: armada8k: add support for gpio controlled reset signal In-reply-to: <20181116121043.GC3228@e107981-ln.cambridge.arm.com> Date: Wed, 21 Nov 2018 09:09:46 +0200 Message-ID: <874lcagb45.fsf@tkos.co.il> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Thomas, As the listed maintainer of this driver, can you review this patch? This patch makes the PCIe slot reset sequence independent from the bootloader. Thanks, baruch Lorenzo Pieralisi writes: > On Wed, Oct 03, 2018 at 04:35:43PM +0300, Baruch Siach wrote: >> On Wed, Oct 03, 2018 at 03:28:11PM +0200, Andrew Lunn wrote: >> > On Wed, Oct 03, 2018 at 03:49:43PM +0300, Baruch Siach wrote: >> > > This commit adds support for the gpio reset signal binding as described >> > > in the designware-pcie.txt DT binding document. Both the documented >> > > 'reset-gpio' property name, and the more standard 'reset-gpios' name are >> > > supported. >> > >> > I don't know this code at all, so maybe a dumb question. Why support >> > the old none-standard binding of reset-gpio on new hardware? I'm >> > assuming reset-gpio is marked a deprecated and reset-gpios is >> > recommended? >> >> This is all hidden behind the devm_gpiod_get_optional() call that only sees >> the "reset" string. The generic code supports both the new property name and >> also the older one for backward compatibility. This patch changes nothing in >> this regard. >> >> The designware-pcie.txt document mentions the older 'reset-gpio' name. So I >> mentioned that name as well in the commit log. > > I need Thomas' ACK to proceed with this patch. > > Thanks, > Lorenzo -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -