linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Lukas Wunner <lukas@wunner.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Crystal Wood <crwood@redhat.com>, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	linux-kernel@vger.kernel.org,
	Attila Fazekas <afazekas@redhat.com>,
	linux-pci@vger.kernel.org, linux-rt-devel@lists.linux.dev,
	Bjorn Helgaas <helgaas@kernel.org>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	Oliver OHalloran <oohall@gmail.com>
Subject: Re: [PATCH] genirq/manage: Reduce priority of forced secondary IRQ handler
Date: Sun, 21 Sep 2025 20:15:09 +0200	[thread overview]
Message-ID: <877bxr65aq.ffs@tglx> (raw)
In-Reply-To: <aM_5uXlknW286cfg@wunner.de>

On Sun, Sep 21 2025 at 15:12, Lukas Wunner wrote:
> On Sat, Sep 20, 2025 at 11:20:26PM +0200, Thomas Gleixner wrote:
> Your research that at first glance, at least 21 of 40 instances of
> request_threaded_irq() could just use IRQF_NO_THREAD, seems to
> support the notion that the majority of interrupt handlers only
> do minimal work in hard interrupt context.
>
> But if that is the case, and if you believe that deferring that
> small amount of work to a thread is nonsensical, then why is the
> primary handler forced into a thread by default in the first place,
> requiring drivers to explicitly opt out by setting IRQF_NO_THREAD?

Because there are primary handlers which are absolutely not RT safe.

> Shouldn't it rather be the other way round, i.e. by default the
> primary handler is *not* forced into a thread, but only if the
> driver explicitly opts in?  (In cases where the primary handler
> does a sufficient amount of work that is justified to be deferred
> to a thread.)

We had to do it this way before RT got upstream as there was no way to
play a whack a mole game with drivers constantly being added and
changed.

Thanks,

        tglx



  reply	other threads:[~2025-09-21 18:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 16:08 [PATCH] genirq/manage: Reduce priority of forced secondary IRQ handler Lukas Wunner
2025-09-17 14:56 ` Sebastian Andrzej Siewior
2025-09-20 21:20 ` Thomas Gleixner
2025-09-21 13:12   ` Lukas Wunner
2025-09-21 18:15     ` Thomas Gleixner [this message]
2025-10-03 18:25     ` Crystal Wood
2025-10-24 13:33       ` Sebastian Andrzej Siewior
2025-10-24 21:00         ` Crystal Wood
2025-10-27  6:40           ` Lukas Wunner
2025-10-27  8:18             ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877bxr65aq.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=afazekas@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=bsegall@google.com \
    --cc=clrkwllms@kernel.org \
    --cc=crwood@redhat.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=helgaas@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=lukas@wunner.de \
    --cc=mahesh@linux.ibm.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=oohall@gmail.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).