From: Thomas Gleixner <tglx@linutronix.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Hans Zhang <18255117159@163.com>
Cc: kw@linux.com, kwilczynski@kernel.org, bhelgaas@google.com,
cassel@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genirq/msi: Add the address and data that show MSI/MSIX
Date: Thu, 27 Feb 2025 18:51:39 +0100 [thread overview]
Message-ID: <877c5be0no.ffs@tglx> (raw)
In-Reply-To: <20250227163937.wv4hsucatyandde3@thinkpad>
On Thu, Feb 27 2025 at 22:09, Manivannan Sadhasivam wrote:
> On Fri, Feb 28, 2025 at 12:28:21AM +0800, Hans Zhang wrote:
>> + return sysfs_emit(
>> + buf,
>> + "%s\n address_hi: 0x%08x\n address_lo: 0x%08x\n msg_data: 0x%08x\n",
>> + is_msix ? "msix" : "msi", desc->msg.address_hi,
>> + desc->msg.address_lo, desc->msg.data);
>
> Sysfs is an ABI. You cannot change the semantics of an attribute.
Correct. Aside of that this is debug information and has no business in
sysfs.
The obvious place to expose this is via the existing debugfs irq/*
mechanism. All it requires is to implement a debug_show() callback in
the MSI core code and assign it to domain ops::debug_show() on domain
creation, if it does not provide its own callback.
Thanks,
tglx
next prev parent reply other threads:[~2025-02-27 17:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 16:28 [PATCH] genirq/msi: Add the address and data that show MSI/MSIX Hans Zhang
2025-02-27 16:39 ` Manivannan Sadhasivam
2025-02-27 16:49 ` Hans Zhang
2025-02-27 18:03 ` Frank Li
2025-02-28 9:00 ` Hans Zhang
2025-02-27 17:51 ` Thomas Gleixner [this message]
2025-02-28 9:04 ` Hans Zhang
2025-02-28 11:26 ` Thomas Gleixner
2025-02-28 15:17 ` Hans Zhang
2025-02-28 18:14 ` Thomas Gleixner
2025-03-01 12:33 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c5be0no.ffs@tglx \
--to=tglx@linutronix.de \
--cc=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=kw@linux.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox