Re: [PATCH v2 06/19] dt-bindings: net: mscc-miim: Add resets property

Krzysztof Kozlowski
2024-05-28T06:45:09Z

On 27/05/2024 18:14, Herve Codina wrote:
> Add the (optional) resets property.
> The mscc-miim device is impacted by the switch reset especially when the
> mscc-miim device is used as part of the LAN966x PCI device.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> Documentation/devicetree/bindings/net/mscc,miim.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mscc,miim.yaml b/Documentation/devicetree/bindings/net/mscc,miim.yaml
> index 5b292e7c9e46..c67e8caa36cf 100644
> --- a/Documentation/devicetree/bindings/net/mscc,miim.yaml
> +++ b/Documentation/devicetree/bindings/net/mscc,miim.yaml
> @@ -38,6 +38,17 @@ properties:
>
> clock-frequency: true
>
> + resets:
> + items:
> + - description:
> + Optional shared switch reset.

If there is going to be resend - drop "optional". You are repeating the
schema in free-form text. No need to resend only for this. Actually drop
entire sentence - it says nothing more than what next sentence is saying.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof