From: Cornelia Huck <cohuck@redhat.com>
To: Leon Romanovsky <leonro@nvidia.com>
Cc: Yishai Hadas <yishaih@nvidia.com>,
alex.williamson@redhat.com, bhelgaas@google.com, jgg@nvidia.com,
saeedm@nvidia.com, linux-pci@vger.kernel.org,
kvm@vger.kernel.org, netdev@vger.kernel.org, kuba@kernel.org,
kwankhede@nvidia.com, mgurtovoy@nvidia.com, maorg@nvidia.com
Subject: Re: [PATCH V4 mlx5-next 06/13] vfio: Fix VFIO_DEVICE_STATE_SET_ERROR macro
Date: Tue, 26 Oct 2021 18:57:59 +0200 [thread overview]
Message-ID: <87bl3bd8q0.fsf@redhat.com> (raw)
In-Reply-To: <YXgv29Og1Ds2mMSS@unreal>
On Tue, Oct 26 2021, Leon Romanovsky <leonro@nvidia.com> wrote:
> On Tue, Oct 26, 2021 at 06:32:08PM +0200, Cornelia Huck wrote:
>> On Tue, Oct 26 2021, Leon Romanovsky <leonro@nvidia.com> wrote:
>>
>> > On Tue, Oct 26, 2021 at 05:32:19PM +0200, Cornelia Huck wrote:
>> >> On Tue, Oct 26 2021, Yishai Hadas <yishaih@nvidia.com> wrote:
>> >>
>> >> > Fixed the non-compiled macro VFIO_DEVICE_STATE_SET_ERROR (i.e. SATE
>> >> > instead of STATE).
>> >> >
>> >> > Fixes: a8a24f3f6e38 ("vfio: UAPI for migration interface for device state")
>> >> > Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
>> >> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>> >>
>> >> This s-o-b chain looks weird; your s-o-b always needs to be last.
>> >
>> > It is not such clear as it sounds.
>> >
>> > Yishai is author of this patch and at some point of time, this patch passed
>> > through my tree and it will pass again, when we will merge it. This is why
>> > my SOB is last and not Yishai's.
>>
>> Strictly speaking, the chain should be Yishai->you->Yishai and you'd add
>> your s-o-b again when you pick it. Yeah, that looks like overkill; the
>> current state just looks weird to me, but I'll shut up now.
>
> We will get checkpatch warning about duplicated signature.
>
> WARNING: Duplicate signature
> #11:
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> total: 0 errors, 1 warnings, 86 lines checked
...this looks more like a bug in checkpatch to me, as it is possible for
a patch to go through the same person twice.
But I'll really shut up now.
next prev parent reply other threads:[~2021-10-26 16:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 9:05 [PATCH V4 mlx5-next 00/13] Add mlx5 live migration driver Yishai Hadas
2021-10-26 9:05 ` [PATCH V4 mlx5-next 01/13] PCI/IOV: Add pci_iov_vf_id() to get VF index Yishai Hadas
2021-10-26 9:05 ` [PATCH V4 mlx5-next 02/13] net/mlx5: Reuse exported virtfn index function call Yishai Hadas
2021-10-26 9:05 ` [PATCH V4 mlx5-next 03/13] net/mlx5: Disable SRIOV before PF removal Yishai Hadas
2021-10-26 9:05 ` [PATCH V4 mlx5-next 04/13] PCI/IOV: Add pci_iov_get_pf_drvdata() to allow VF reaching the drvdata of a PF Yishai Hadas
2021-10-26 9:05 ` [PATCH V4 mlx5-next 05/13] net/mlx5: Expose APIs to get/put the mlx5 core device Yishai Hadas
2021-10-26 9:05 ` [PATCH V4 mlx5-next 06/13] vfio: Fix VFIO_DEVICE_STATE_SET_ERROR macro Yishai Hadas
2021-10-26 15:32 ` Cornelia Huck
2021-10-26 15:50 ` Alex Williamson
2021-10-26 15:56 ` Cornelia Huck
2021-10-26 16:18 ` Leon Romanovsky
2021-10-26 16:32 ` Cornelia Huck
2021-10-26 16:42 ` Leon Romanovsky
2021-10-26 16:57 ` Cornelia Huck [this message]
2021-10-26 9:05 ` [PATCH V4 mlx5-next 07/13] vfio: Add a macro for VFIO_DEVICE_STATE_ERROR Yishai Hadas
2021-10-26 15:37 ` Cornelia Huck
2021-10-26 9:06 ` [PATCH V4 mlx5-next 08/13] vfio/pci_core: Make the region->release() function optional Yishai Hadas
2021-10-26 9:06 ` [PATCH V4 mlx5-next 09/13] net/mlx5: Introduce migration bits and structures Yishai Hadas
2021-10-26 9:06 ` [PATCH V4 mlx5-next 10/13] vfio/mlx5: Expose migration commands over mlx5 device Yishai Hadas
2021-10-26 9:06 ` [PATCH V4 mlx5-next 11/13] vfio/mlx5: Implement vfio_pci driver for mlx5 devices Yishai Hadas
2021-10-26 22:42 ` Alex Williamson
2021-10-26 23:46 ` Jason Gunthorpe
2021-10-26 9:06 ` [PATCH V4 mlx5-next 12/13] vfio/pci: Expose vfio_pci_aer_err_detected() Yishai Hadas
2021-10-26 22:45 ` Alex Williamson
2021-10-26 9:06 ` [PATCH V4 mlx5-next 13/13] vfio/mlx5: Use its own PCI reset_done error handler Yishai Hadas
2021-10-26 23:16 ` Alex Williamson
2021-10-26 23:50 ` Jason Gunthorpe
2021-10-27 15:29 ` Alex Williamson
2021-10-27 15:53 ` Jason Gunthorpe
2021-10-27 16:48 ` Alex Williamson
2021-10-27 16:53 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl3bd8q0.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).