From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6776C04E69 for ; Wed, 2 Aug 2023 15:58:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232654AbjHBP63 (ORCPT ); Wed, 2 Aug 2023 11:58:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235349AbjHBP5x (ORCPT ); Wed, 2 Aug 2023 11:57:53 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03DBE2685 for ; Wed, 2 Aug 2023 08:57:47 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B86F71F381; Wed, 2 Aug 2023 15:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690991865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y4cKrxXTYWisN5RcuPHnoaVpyBNRXGNZ0s9ctVTI9Yw=; b=WMRCBDYFb53QGu4H4gc4yHEbyMMtEPD1aNbvV0uJaKo5/eVUq6afxARy/cqgEpoa4e7DuG ngNtErUvq0Ju2cqecycIZg3e/gkMfMxLaV61JybE5SzQTzjkyYOHmn/ai4xHFf4DH2U5Qi szybTY+V7hHWfem18pzgvmeXkwUiMIo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690991865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y4cKrxXTYWisN5RcuPHnoaVpyBNRXGNZ0s9ctVTI9Yw=; b=AoPfyvsw1n456CD3En7CnsBBxSriFplxFtgVgcILM+h7LdDTTo+1q0JbJwhuDgqjbJqlAi IXbvqhRTpeAcL5Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 830E013909; Wed, 2 Aug 2023 15:57:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id INQVH/l8ymTHPAAAMHmgww (envelope-from ); Wed, 02 Aug 2023 15:57:45 +0000 Date: Wed, 02 Aug 2023 17:57:45 +0200 Message-ID: <87fs51cu86.wl-tiwai@suse.de> From: Takashi Iwai To: Bjorn Helgaas Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, broonie@kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Ranjani Sridharan , Bard Liao Subject: Re: [PATCH 1/5] PCI: add ArrowLake-S PCI ID for Intel HDAudio subsystem. In-Reply-To: <20230802155226.GA59821@bhelgaas> References: <20230802150105.24604-2-pierre-louis.bossart@linux.intel.com> <20230802155226.GA59821@bhelgaas> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, 02 Aug 2023 17:52:26 +0200, Bjorn Helgaas wrote: > > On Wed, Aug 02, 2023 at 10:01:01AM -0500, Pierre-Louis Bossart wrote: > > Add part ID to common include file > > Please drop period at end of subject and add one at the end of the > commit log. > > Also mention the drivers that will use this new #define; looks like > hda_intel.c and ... > > Well, actually, I only see that one use, which means we probably > shouldn't add this #define to pci_ids.h, per the comment at the top of > the file. If there's only one use, use the hex ID in the driver (or > add a #define in the driver itself). Judging from the previous patterns, the same ID could be required for ASoC SOF driver, too, which isn't included in this patch set. In that case, it's worth to put to pci_ids.h. (OTOH, it can be done at a later stage, too.) thanks, Takashi