From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E640C4338F for ; Sat, 14 Aug 2021 09:45:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2324C60EFE for ; Sat, 14 Aug 2021 09:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbhHNJp4 (ORCPT ); Sat, 14 Aug 2021 05:45:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:36270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231683AbhHNJpt (ORCPT ); Sat, 14 Aug 2021 05:45:49 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB9F060EFE; Sat, 14 Aug 2021 09:45:21 +0000 (UTC) Received: from 109-170-232-56.xdsl.murphx.net ([109.170.232.56] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mEqEB-004xOs-Ls; Sat, 14 Aug 2021 10:45:19 +0100 Date: Sat, 14 Aug 2021 10:45:19 +0100 Message-ID: <87fsvc1hsg.wl-maz@kernel.org> From: Marc Zyngier To: Barry Song <21cnbao@gmail.com> Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, bhelgaas@google.com, dwmw@amazon.co.uk, gregkh@linuxfoundation.org, linux-pci@vger.kernel.org, linuxarm@huawei.com, lorenzo.pieralisi@arm.com, rafael@kernel.org, robin.murphy@arm.com, song.bao.hua@hisilicon.com, will@kernel.org Subject: Re: [PATCH v3 0/2] msi: extend msi_irqs sysfs entries to platform devices In-Reply-To: <20210813035628.6844-1-21cnbao@gmail.com> References: <20210813035628.6844-1-21cnbao@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 109.170.232.56 X-SA-Exim-Rcpt-To: 21cnbao@gmail.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, bhelgaas@google.com, dwmw@amazon.co.uk, gregkh@linuxfoundation.org, linux-pci@vger.kernel.org, linuxarm@huawei.com, lorenzo.pieralisi@arm.com, rafael@kernel.org, robin.murphy@arm.com, song.bao.hua@hisilicon.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 13 Aug 2021 04:56:26 +0100, Barry Song <21cnbao@gmail.com> wrote: > > From: Barry Song > > -v3: > added Acked-by of Greg Kroah-Hartman and Bjorn Helgaas, thanks! > refined commit log with respect to Bjorn's comments > > Hi Thomas & Marc, > Would you please handle this series? Thanks! > > -v2: > extract common code for msi_irqs sysfs populate/destory from PCI to MSI core, > platform_device can directly reuse common code; > https://lore.kernel.org/lkml/20210812105341.51657-1-21cnbao@gmail.com/ > > -v1: > https://lore.kernel.org/lkml/20210811105020.12980-1-song.bao.hua@hisilicon.com/ > > Just like pci devices have msi_irqs which can be used by userspace irq affinity > tools or applications to bind irqs, platform devices also widely support msi > irqs. > For platform devices, for example ARM SMMU, userspaces also care about its msi > irqs as applications can know the mapping between devices and irqs and then > make smarter decision on handling irq affinity. For example, for SVA mode, > it is better to pin io page fault to the numa node applications are running > on. Otherwise, io page fault will get a remote page from the node iopf happens > rather than from the node applications are running on. > > The first patch extracts the sysfs populate/destory code from PCI to > MSI core. The 2nd patch lets platform-msi export msi_irqs entry so that > userspace can know the mapping between devices and irqs for platform > devices. Although I'm not in a position to test it right now, this looks reasonable to me: Acked-by: Marc Zyngier Thomas, do you want to queue this one, given that you already carry a ton of MSI-related patches? Thanks, M. -- Without deviation from the norm, progress is not possible.