Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Manoj Iyer <manoj.iyer@canonical.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
	matsumur@nts.ricoh.co.jp, linux-pci@vger.kernel.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency
Date: Wed, 21 Nov 2012 19:29:46 -0500	[thread overview]
Message-ID: <87obiqa39h.fsf@octavius.laptop.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1107181546100.1677@lazy> (Manoj Iyer's message of "Mon, 18 Jul 2011 15:47:33 -0500 (CDT)")

Hi Manoj, Matsumuro-san,

On Mon, Jul 18 2011, Manoj Iyer wrote:
> Right, without the patch I get..
>
> [   52.526665] mmc0: new SDHC card at address e624
> [   52.571228] mmcblk0: mmc0:e624 SD16G 14.8 GiB
> [   52.591071] mmcblk0: retrying using single block read
> [   52.593105] mmcblk0: error -84 transferring data, sector 0, nr 8,
> card status 0x900
> [   52.593109] end_request: I/O error, dev mmcblk0, sector 0
> [   52.594594] mmcblk0: error -84 transferring data, sector 1, nr 7,
> card status 0x900
> [   52.594604] end_request: I/O error, dev mmcblk0, sector 1
> [   52.602893] quiet_error: 24 callbacks suppressed
> [   52.602902] Buffer I/O error on device mmcblk0, logical block 0
> [   52.605349] ldm_validate_partition_table(): Disk read failed.
> [   52.605384] Dev mmcblk0: unable to read RDB block 0
> [   52.607729]  mmcblk0: unable to read partition table
> u@u:~$
>
> So, I cannot generate any comparison data with this SD card.

I don't know if you remember this bug, but I have reports from two users
who see "error -84"s on :e823 controllers even with this patch active on
modern ThinkPads.

Maybe 50MHz isn't low enough sometimes?  Is it possible to lower the base
clock further?

I noticed that the frequency is encoded ine one of the PCI writes:
+        * 0x32  - 50Mhz new clock frequency

So if I get access to one of these systems, I might try lowering that
value (by half, say) and see what happens.  But at the moment I haven't
found someone who's willing to try kernel patches yet, and I don't have
one of these systems myself.

Thanks!

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

       reply	other threads:[~2012-11-22  0:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1310419715-13254-1-git-send-email-manoj.iyer@canonical.com>
     [not found] ` <m2sjqa2q93.fsf@bob.laptop.org>
     [not found]   ` <alpine.DEB.2.02.1107131031360.3174@lazy>
     [not found]     ` <201107131835.25217.arnd@arndb.de>
     [not found]       ` <alpine.DEB.2.02.1107131144250.3174@lazy>
     [not found]         ` <m21uxu2k96.fsf@bob.laptop.org>
     [not found]           ` <alpine.DEB.2.02.1107131157440.3174@lazy>
     [not found]             ` <m2wrfm1537.fsf@bob.laptop.org>
     [not found]               ` <alpine.DEB.2.02.1107181535250.1677@lazy>
     [not found]                 ` <m2zkkbb9vn.fsf@bob.laptop.org>
     [not found]                   ` <alpine.DEB.2.02.1107181546100.1677@lazy>
2012-11-22  0:29                     ` Chris Ball [this message]
2012-11-26 16:42                       ` [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency Manoj Iyer
2012-11-26 16:57                         ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obiqa39h.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=arnd@arndb.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=manoj.iyer@canonical.com \
    --cc=matsumur@nts.ricoh.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox