Re: [PATCH v4 06/12] PCI: aardvark: Add FIXME comment for PCIE_CORE_CMD_STATUS_REG access

Rob Herring
2020-05-07T21:21:00Z

On Thu, 30 Apr 2020 10:06:19 +0200, =?UTF-8?q?Pali=20Roh=C3=A1r?= wrote:
> This register is applicable only when the controller is configured for
> Endpoint mode, which is not the case for the current version of this
> driver.
>
> Attempting to remove this code though caused some ath10k cards to stop
> working, so for some unknown reason it is needed here.
>
> This should be investigated and a comment explaining this should be put
> before the code, so we add a FIXME comment for now.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/pci/controller/pci-aardvark.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>

Acked-by: Rob Herring <robh@kernel.org>