From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87800C433EF for ; Thu, 28 Oct 2021 15:24:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70458610CB for ; Thu, 28 Oct 2021 15:24:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230340AbhJ1P0h convert rfc822-to-8bit (ORCPT ); Thu, 28 Oct 2021 11:26:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:38422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbhJ1P0h (ORCPT ); Thu, 28 Oct 2021 11:26:37 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 543CB60FF2; Thu, 28 Oct 2021 15:24:10 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mg7GC-002FD8-F8; Thu, 28 Oct 2021 16:24:08 +0100 Date: Thu, 28 Oct 2021 16:24:08 +0100 Message-ID: <87r1c59nqf.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Lorenzo Pieralisi , Marek =?UTF-8?B?QmVo?= =?UTF-8?B?w7pu?= , Bjorn Helgaas , linux-pci@vger.kernel.org Subject: Re: [PATCH 10/14] PCI: aardvark: Enable MSI-X support In-Reply-To: <20211028113724.gm6zhqt7qcyxtgkq@pali> References: <20211012164145.14126-1-kabel@kernel.org> <20211012164145.14126-11-kabel@kernel.org> <20211027141246.GA27543@lpieralisi> <20211027142307.lrrix5yfvroxl747@pali> <20211028110835.GA1846@lpieralisi> <20211028111302.gfd73ifoyudttpee@pali> <20211028113030.GA2026@lpieralisi> <20211028113724.gm6zhqt7qcyxtgkq@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, lorenzo.pieralisi@arm.com, kabel@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, 28 Oct 2021 12:37:24 +0100, Pali Rohár wrote: > > On Thursday 28 October 2021 12:30:30 Lorenzo Pieralisi wrote: > > On Thu, Oct 28, 2021 at 01:13:02PM +0200, Pali Rohár wrote: > > > > [...] > > > > > > > In commit message I originally tried to explain it that after applying > > > > > all previous patches which are fixing MSI and Multi-MSI support (part of > > > > > them is enforcement to use only MSI numbers 0..31), it makes driver > > > > > compatible with also MSI-X interrupts. > > > > > > > > > > If you want to rewrite commit message, let us know, there is no problem. > > > > > > > > I think we should. > > > > > > > > > > > Signed-off-by: Pali Rohár > > > > > > > Reviewed-by: Marek Behún > > > > > > > > By the way, this tag should be removed. Marek signed it off, that > > > > applies to other patches in this series as well. > > > > > > Ok! Is this the only issue with this patch series? Or something other > > > needs to be fixed? > > > > The series looks fine to me - only thing for patch[4-10] I'd like > > to have evidence MarcZ is happy with the approach > > Marc, could you look at patches 4-10 if you are happy with them? Link: > https://lore.kernel.org/linux-pci/20211012164145.14126-5-kabel@kernel.org/ Started with patch #4, and saw that you are still using irq_find_mapping + generic_handle_irq which I objected to every time I looked at this patch ([1], [2]). My NAK still stands, and I haven't looked any further, because you obviously don't really care about review comments. M. [1] https://lore.kernel.org/r/8735r0qfab.wl-maz@kernel.org [2] https://lore.kernel.org/r/871r6kqf2d.wl-maz@kernel.org -- Without deviation from the norm, progress is not possible.