* [PATCH] PCI: apple: Enable clock gating
@ 2021-11-17 14:19 Hector Martin
2021-11-17 17:56 ` Marc Zyngier
2021-11-30 16:44 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Hector Martin @ 2021-11-17 14:19 UTC (permalink / raw)
To: Marc Zyngier, Alyssa Rosenzweig
Cc: Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas, linux-pci, linux-kernel, Hector Martin
These pokes are not required to make the PCIe port work, but it sounds
like this should save some power at least.
Signed-off-by: Hector Martin <marcan@marcan.st>
---
drivers/pci/controller/pcie-apple.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
index 420c291a5c68..03bfe977c579 100644
--- a/drivers/pci/controller/pcie-apple.c
+++ b/drivers/pci/controller/pcie-apple.c
@@ -553,6 +553,9 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie,
return ret;
}
+ rmw_clear(PORT_REFCLK_CGDIS, port->base + PORT_REFCLK);
+ rmw_clear(PORT_APPCLK_CGDIS, port->base + PORT_APPCLK);
+
ret = apple_pcie_port_setup_irq(port);
if (ret)
return ret;
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: apple: Enable clock gating
2021-11-17 14:19 [PATCH] PCI: apple: Enable clock gating Hector Martin
@ 2021-11-17 17:56 ` Marc Zyngier
2021-11-30 16:44 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2021-11-17 17:56 UTC (permalink / raw)
To: Hector Martin
Cc: Alyssa Rosenzweig, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, linux-pci, linux-kernel
On Wed, 17 Nov 2021 14:19:16 +0000,
Hector Martin <marcan@marcan.st> wrote:
>
> These pokes are not required to make the PCIe port work, but it sounds
> like this should save some power at least.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> drivers/pci/controller/pcie-apple.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> index 420c291a5c68..03bfe977c579 100644
> --- a/drivers/pci/controller/pcie-apple.c
> +++ b/drivers/pci/controller/pcie-apple.c
> @@ -553,6 +553,9 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie,
> return ret;
> }
>
> + rmw_clear(PORT_REFCLK_CGDIS, port->base + PORT_REFCLK);
> + rmw_clear(PORT_APPCLK_CGDIS, port->base + PORT_APPCLK);
> +
> ret = apple_pcie_port_setup_irq(port);
> if (ret)
> return ret;
> --
> 2.33.0
>
>
Acked-by: Marc Zyngier <maz@kernel.org>
Tested-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: apple: Enable clock gating
2021-11-17 14:19 [PATCH] PCI: apple: Enable clock gating Hector Martin
2021-11-17 17:56 ` Marc Zyngier
@ 2021-11-30 16:44 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2021-11-30 16:44 UTC (permalink / raw)
To: Marc Zyngier, Alyssa Rosenzweig, Hector Martin
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński, Bjorn Helgaas,
linux-kernel, linux-pci, Rob Herring
On Wed, 17 Nov 2021 23:19:16 +0900, Hector Martin wrote:
> These pokes are not required to make the PCIe port work, but it sounds
> like this should save some power at least.
>
>
Applied to pci/apple, thanks!
[1/1] PCI: apple: Enable clock gating
https://git.kernel.org/lpieralisi/pci/c/754bb7ad29
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-30 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-17 14:19 [PATCH] PCI: apple: Enable clock gating Hector Martin
2021-11-17 17:56 ` Marc Zyngier
2021-11-30 16:44 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).