From: Thomas Gleixner <tglx@linutronix.de>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>, linux-pci@vger.kernel.org
Cc: "Marek Vasut" <marek.vasut+renesas@mailbox.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jisheng Zhang" <Jisheng.Zhang@synaptics.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Marc Zyngier" <maz@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] [RFC] genirq/cpuhotplug, PCI/rcar-host: Silence set affinity failed warning
Date: Sun, 14 Jul 2024 21:14:24 +0200 [thread overview]
Message-ID: <87wmlnrdkf.ffs@tglx> (raw)
In-Reply-To: <20240714122405.27548-1-marek.vasut+renesas@mailbox.org>
Marek!
On Sun, Jul 14 2024 at 14:23, Marek Vasut wrote:
> --- a/drivers/base/platform-msi.c
> +++ b/drivers/base/platform-msi.c
> @@ -100,7 +100,7 @@ static void platform_msi_update_chip_ops(struct msi_domain_info *info)
> chip->irq_unmask = irq_chip_unmask_parent;
> if (!chip->irq_eoi)
> chip->irq_eoi = irq_chip_eoi_parent;
> - if (!chip->irq_set_affinity)
> + if (!chip->irq_set_affinity && !(info->flags & MSI_FLAG_USE_DEF_CHIP_OPS_NOAFF))
> chip->irq_set_affinity = msi_domain_set_affinity;
I'm not really a fan of this new flag.
I'd rather leave MSI_FLAG_USE_DEF_CHIP_OPS alone and introduce a
dedicated flag MSI_FLAG_NO_AFFINITY to tell the core code that these
interrupts cannot be steered. Other than that this approach looks sane.
Thanks,
tglx
next prev parent reply other threads:[~2024-07-14 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 12:23 [PATCH v2] [RFC] genirq/cpuhotplug, PCI/rcar-host: Silence set affinity failed warning Marek Vasut
2024-07-14 19:14 ` Thomas Gleixner [this message]
2024-07-15 12:26 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmlnrdkf.ffs@tglx \
--to=tglx@linutronix.de \
--cc=Jisheng.Zhang@synaptics.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).