From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Daniel Axtens To: Michael Ellerman , linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code In-Reply-To: <87efsnq217.fsf@concordia.ellerman.id.au> References: <20170804102033.27731-1-dja@axtens.net> <20170804102033.27731-4-dja@axtens.net> <87efsnq217.fsf@concordia.ellerman.id.au> Date: Tue, 08 Aug 2017 09:01:06 +1000 Message-ID: <87wp6fq8y5.fsf@linkitivity.dja.id.au> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gabriele.paoloni@huawei.com, airlied@linux.ie, catalin.marinas@arm.com, will.deacon@arm.com, z.liuxinliang@hisilicon.com, bhelgaas@google.com, alex.williamson@redhat.com, zourongrong@gmail.com, Brian King , daniel.vetter@intel.com Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Michael Ellerman writes: > Daniel Axtens writes: > >> Currently, we do a PCI fixup to mark a default card so that Xorg >> autoconfiguration works. >> >> There is a new generic method to do this sort of vga fixup, and >> it occurs by default. >> >> Drop our old method. >> >> This method is different: >> - it will only mark a card as default if a driver is bound >> - the marking will happen at late_initcall time, or even later >> if a card is enabled later on (via an ENABLE hook). Currently >> things are enabled in a FINAL hook. >> >> This *does* change behaviour under some circumstances. >> >> For example, pseries_le_defconfig doesn't have DRM drivers for >> many of the qemu GPU models, including the 'standard' vga. > > Should we enable them/it? Hard to say. The 'standard' vga module (bochs_drm) was blacklisted by Ubuntu - apparently at IBM's request [0] - some years back. Even if you un-blacklist it, I had trouble with getting it and the openfirmware framebuffer driver to play nicely together. It may not be worth the trouble for bochs_drm. There's a better case for including some of the more modern drivers - maybe QXL and virtio - but I wasn't able to test them: my particular build of qemu/TCG refused to start with them and I didn't feel like rebuilding/debugging qemu. It would also be legitmate to say that you're focussing on headless use with pseries_*defconfig and not include them: you need to bring in the DRM core if you want these drivers. HTH. Regards, Daniel [0] https://bugs.launchpad.net/ubuntu/+source/kmod/+bug/1378648 > > cheers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel