Re: [PATCH v2 0/2] PCI/AER: Report fatal errors of RCiEP and EP if link recoverd

Shuai Xue
2024-12-24T11:03:54Z

在 2024/11/12 21:54, Shuai Xue 写道:
> changes since v1:
> - rewrite commit log per Bjorn
> - refactor aer_get_device_error_info to reduce duplication per Keith
> - fix to avoid reporting fatal errors twice for root and downstream ports per Keith
>
> The AER driver has historically avoided reading the configuration space of an
> endpoint or RCiEP that reported a fatal error, considering the link to that
> device unreliable. Consequently, when a fatal error occurs, the AER and DPC
> drivers do not report specific error types, resulting in logs like:
>
> pcieport 0000:30:03.0: EDR: EDR event received
> pcieport 0000:30:03.0: DPC: containment event, status:0x0005 source:0x3400
> pcieport 0000:30:03.0: DPC: ERR_FATAL detected
> pcieport 0000:30:03.0: AER: broadcast error_detected message
> nvme nvme0: frozen state error detected, reset controller
> nvme 0000:34:00.0: ready 0ms after DPC
> pcieport 0000:30:03.0: AER: broadcast slot_reset message
>
> AER status registers are sticky and Write-1-to-clear. If the link recovered
> after hot reset, we can still safely access AER status of the error device.
> In such case, report fatal errors which helps to figure out the error root
> case.
>
> - Patch 1/2 identifies the error device by SOURCE ID register
> - Patch 2/3 reports the AER status if link recoverd.
>
> After this patch set, the logs like:
>
> pcieport 0000:30:03.0: EDR: EDR event received
> pcieport 0000:30:03.0: DPC: containment event, status:0x0005 source:0x3400
> pcieport 0000:30:03.0: DPC: ERR_FATAL detected
> pcieport 0000:30:03.0: AER: broadcast error_detected message
> nvme nvme0: frozen state error detected, reset controller
> pcieport 0000:30:03.0: waiting 100 ms for downstream link, after activation
> nvme 0000:34:00.0: ready 0ms after DPC
> nvme 0000:34:00.0: PCIe Bus Error: severity=Uncorrectable (Fatal), type=Data Link Layer, (Receiver ID)
> nvme 0000:34:00.0: device [144d:a804] error status/mask=00000010/00504000
> nvme 0000:34:00.0: [ 4] DLP (First)
> pcieport 0000:30:03.0: AER: broadcast slot_reset message
>
> Shuai Xue (2):
> PCI/DPC: Run recovery on device that detected the error
> PCI/AER: Report fatal errors of RCiEP and EP if link recoverd
>
> drivers/pci/pci.h | 5 +++--
> drivers/pci/pcie/aer.c | 11 +++++++----
> drivers/pci/pcie/dpc.c | 32 +++++++++++++++++++++++++-------
> drivers/pci/pcie/edr.c | 35 ++++++++++++++++++-----------------
> drivers/pci/pcie/err.c | 9 +++++++++
> 5 files changed, 62 insertions(+), 30 deletions(-)
>

Hi, all,

Gentle ping.

Best Regards,
Shuai