Re: [PATCH v2] PCI: dw-rockchip: Add system PM support

[Nicolas Frattaroli <nicolas.frattaroli@collabora.com>]

On Tuesday, 15 April 2025 15:09:29 Central European Summer Time Niklas Cassel wrote:
> On Fri, Apr 11, 2025 at 02:14:08PM +0800, Shawn Lin wrote:
> > [...]
> > +      rockchip_pcie_ltssm_enable_control_mode(rockchip, PCIE_CLIENT_RC_MODE);
> 
> Here you are setting PCIE_CLIENT_RC_MODE unconditionally.
> 
> I really don't think that you have tested these callbacks with EP mode.

Hi Niklas,

I may be reading too much into your tone here, but I think it'd be good if
you didn't formulate this in such a passive-aggressive accusatory way. You
can just express your concern as a question about whether this was tested
with EP mode.

After all, I'm giving you specifically the same benefit of the doubt with
RC mode that has broken BAR resource mapping on RK3588 in timing-related
ways in v6.15-rc that has already taken me about a day of unreliable
bisects to try and track down, and may in fact end up bisecting to one of
your recent commits touching that part.

> 
> If we look at pcie-qcom.c and pcie-qcom-ep.c, dev_pm_ops is defined in
> pcie-qcom.c, but not in pcie-qcom-ep.c.
> 
> Perhaps it is starting to be time to have two separate drivers also for
> rockchip?
> 
> [...]

Regards,
Nicolas Frattaroli