From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB36C64EC7 for ; Wed, 22 Feb 2023 16:03:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231418AbjBVQDf (ORCPT ); Wed, 22 Feb 2023 11:03:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231562AbjBVQDe (ORCPT ); Wed, 22 Feb 2023 11:03:34 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DA32EB43 for ; Wed, 22 Feb 2023 08:03:32 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id y14so1197461ljq.4 for ; Wed, 22 Feb 2023 08:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NR4JoHyWqAKZMIzu2agHedJCOBnxsQp20MwXG8k1Puk=; b=XoG4ZrzArjsq7Gys9DInrt0BXC6yUUa10LZOtyr+49aL9ySph3lolrX2018HGVKZ9c qpO4Zw147BmOkwfn3oe/5r5a2jMqswgJfQ6lc2FJVRQip4Tlur8ueAu7BRXziLZR5BnA YaEtQuPRDbDg5adgJk3lciWCNJyQJ4F7uqiB45adtPy/eLy05Oh4/VucXwDka7SohsyD rvg51xSyI3BYAGvYEs++gjFIErrDcqvXXP/sg+tAnG5tw29R3eSfrFdSmgZyRHR0wJlQ l4n+fUfJP0VKZHUvQwUgVnZ4yOsfwhFEDU7snyW6nNoaNKBtAUWvJXb+FqySPKFPo/Z9 S9Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NR4JoHyWqAKZMIzu2agHedJCOBnxsQp20MwXG8k1Puk=; b=264SZQGlAc3s4/MjWkmOXE950Fn/DS6ygEfZEgaJisJPkbeXYeuedb2d/l/jwlt31B Uk13P5CA1PGzJz5nKP3fmCz1XZK5lVTzN5FJmOSsYnTVFXc9fwc9SS3jMtLmtnJppLfX B3JI7+mDtbao54vLuMUEecoEJWzEkhJPLR/kI7STQHBefb4/Vmwq0oqCSGGP++zupjCM ntRSygAYqUNNt8+dXaowD4MSO+Aa4ED9SqX3Ux0Oj2wS7uzMbe8jJ9U8MlDOuhUiKwGn WtTmRtTop1m0RyCSrO+xA01jByOYcQb1d253wRs/lAP2EibzuYQ8TH13ZgzKnlwNI1RT MamQ== X-Gm-Message-State: AO0yUKV8UiCKC+iLBn/l3HRc1QjVGDz/rCZfAzsB+QJgjfPqo8/8w4C+ JGFG6blKpoT34t/5r09IeQuCrA== X-Google-Smtp-Source: AK7set+XvU2ChKqYyJqbPojwoDwwVPSMVn2b5ntpK4liomhLzTsVlLZCbwsFo/R0S13FKVlsQeiasg== X-Received: by 2002:a05:651c:4c6:b0:294:751d:d734 with SMTP id e6-20020a05651c04c600b00294751dd734mr4567535lji.31.1677081810317; Wed, 22 Feb 2023 08:03:30 -0800 (PST) Received: from [192.168.1.101] (abxi151.neoplus.adsl.tpnet.pl. [83.9.2.151]) by smtp.gmail.com with ESMTPSA id j16-20020a2e3c10000000b0029352e4ba6esm834767lja.90.2023.02.22.08.03.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 08:03:29 -0800 (PST) Message-ID: <8881b90c-f276-6f14-e161-f07630845257@linaro.org> Date: Wed, 22 Feb 2023 17:03:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 07/11] ARM: dts: qcom: sdx55: Add support for PCIe RC controller Content-Language: en-US To: Manivannan Sadhasivam , andersson@kernel.org, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org Cc: bhelgaas@google.com, kishon@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org References: <20230222153251.254492-1-manivannan.sadhasivam@linaro.org> <20230222153251.254492-8-manivannan.sadhasivam@linaro.org> From: Konrad Dybcio In-Reply-To: <20230222153251.254492-8-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 22.02.2023 16:32, Manivannan Sadhasivam wrote: > The PCIe controller in SDX55 can act as the RC controller also. Let's > add support for it. > > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm/boot/dts/qcom-sdx55.dtsi | 72 +++++++++++++++++++++++++++++++ > 1 file changed, 72 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi > index a1f4a7b0904a..768d7d7f6335 100644 > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi > @@ -303,6 +303,78 @@ qpic_nand: nand-controller@1b30000 { > status = "disabled"; > }; > > + pcie_rc: pcie@1c00000 { > + compatible = "qcom,pcie-sdx55"; > + reg = <0x01c00000 0x3000>, > + <0x40000000 0xf1d>, > + <0x40000f20 0xc8>, > + <0x40001000 0x1000>, > + <0x40100000 0x100000>; > + reg-names = "parf", "dbi", "elbi", "atu", "config"; It'd be nice if this and interrupt-names could be turned into a vertical list of entries, sort of like you have in clock- names. And it'd be even nicer if you could fix that up in both PCIe nodes. Konrad > + device_type = "pci"; > + linux,pci-domain = <0>; > + bus-range = <0x00 0xff>; > + num-lanes = <1>; > + > + #address-cells = <3>; > + #size-cells = <2>; > + > + ranges = <0x01000000 0x0 0x40200000 0x40200000 0x0 0x100000>, > + <0x02000000 0x0 0x40300000 0x40300000 0x0 0x3fd00000>; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "msi", "msi2", "msi3", "msi4", > + "msi5", "msi6", "msi7", "msi8"; > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 0x7>; > + interrupt-map = <0 0 0 1 &intc 0 0 0 141 IRQ_TYPE_LEVEL_HIGH>, /* int_a */ > + <0 0 0 2 &intc 0 0 0 142 IRQ_TYPE_LEVEL_HIGH>, /* int_b */ > + <0 0 0 3 &intc 0 0 0 143 IRQ_TYPE_LEVEL_HIGH>, /* int_c */ > + <0 0 0 4 &intc 0 0 0 144 IRQ_TYPE_LEVEL_HIGH>; /* int_d */ > + > + clocks = <&gcc GCC_PCIE_PIPE_CLK>, > + <&gcc GCC_PCIE_AUX_CLK>, > + <&gcc GCC_PCIE_CFG_AHB_CLK>, > + <&gcc GCC_PCIE_MSTR_AXI_CLK>, > + <&gcc GCC_PCIE_SLV_AXI_CLK>, > + <&gcc GCC_PCIE_SLV_Q2A_AXI_CLK>, > + <&gcc GCC_PCIE_SLEEP_CLK>; > + clock-names = "pipe", > + "aux", > + "cfg", > + "bus_master", > + "bus_slave", > + "slave_q2a", > + "sleep"; > + > + assigned-clocks = <&gcc GCC_PCIE_AUX_CLK>; > + assigned-clock-rates = <19200000>; > + > + iommus = <&apps_smmu 0x0200 0x0f>; > + iommu-map = <0x0 &apps_smmu 0x0200 0x1>, > + <0x100 &apps_smmu 0x0201 0x1>, > + <0x200 &apps_smmu 0x0202 0x1>, > + <0x300 &apps_smmu 0x0203 0x1>, > + <0x400 &apps_smmu 0x0204 0x1>; > + > + resets = <&gcc GCC_PCIE_BCR>; > + reset-names = "pci"; > + > + power-domains = <&gcc PCIE_GDSC>; > + > + phys = <&pcie_lane>; > + phy-names = "pciephy"; > + > + status = "disabled"; > + }; > + > pcie_ep: pcie-ep@1c00000 { > compatible = "qcom,sdx55-pcie-ep"; > reg = <0x01c00000 0x3000>,