From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E31C2B9F4 for ; Mon, 28 Jun 2021 10:57:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF57361A2B for ; Mon, 28 Jun 2021 10:57:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232679AbhF1K76 (ORCPT ); Mon, 28 Jun 2021 06:59:58 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:58957 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232614AbhF1K75 (ORCPT ); Mon, 28 Jun 2021 06:59:57 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3A27232007E8; Mon, 28 Jun 2021 06:57:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 28 Jun 2021 06:57:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm2; bh=i 44yOBTBX/vyWAA4JUgHFd2BT6mpSEt5PeqeW4yz96g=; b=IQ861eI3L83F1yKth pAZiT36GOT/iynCEDQzKex1OZJOubb/wbiFLSdqNRJ8mceF4sEsnFnQQYHuHqnVw LXX4FpEOTcMFVtPRLgC2UnEkb7o59TVfN5/yEOR4pOR4P2h8ic11y3MA8d+t1sjG vYZe0qyTPs2KaoNuxvW20/mxIM8igUvx2IYg9MhdhIrGcOBpgrqdCDrQpgYUFPOD 0O4zJ+QirHl6LiFvK/3rCyAWLgbh91vkSdcwm3DZechw2jaiia0VqqDYm8f6WRya 6YAJiLjaLkyjLSsrAd1D/3BMOAlyb1CXnakFlJ+I1KfyrCAL8FU26OU5frLro7NK EIRQA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=i44yOBTBX/vyWAA4JUgHFd2BT6mpSEt5PeqeW4yz9 6g=; b=IWoky98+qd9CkPqFQpd/Bo3tuuFKMUF4X1li8Rd1G3LhoX/mmOb498ooO V+m9Y94ji68LrAwqBRnW13IQl5XcMO6hJVma3Zr0KdKEmx8Py2xmRSb6uIM5xOQH Qe3t5pqy3LWmuZqGVBU+Vo+6lBDb4ji4Mux39W0E+svwl5uTdivul1h5jnVk8xEa OAFaW665BgroSGYc2g7BDtDFFwT+AGLjag3aX9HziQLsR63HaR7wtUWNEqGzBbBf 5ZNuQ/vUi6JJ0bzxMmj9z5q8x1yJFbEjxE+kV1j/t3Ix+P38xmn1fYGU5gZ4FC1q QnJNuz/4dTmrB1eJi0dbI1olQyv3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeehgedgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhkffffgggjggtgfesthekredttdefjeenucfhrhhomheplfhirgig uhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtohhmqeenuc ggtffrrghtthgvrhhnpeekieeghfffhfeuuddtvdegleeltdejgeevfeekteetheefhffg vefhueetkeefieenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhirgiguhhnrdihrghnghes fhhlhihgohgrthdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Jun 2021 06:57:28 -0400 (EDT) Subject: Re: [PATCH V4 2/4] PCI: Move loongson pci quirks to quirks.c To: Huacai Chen Cc: Huacai Chen , Bjorn Helgaas , linux-pci , Xuefeng Li References: <20210628101027.1372370-1-chenhuacai@loongson.cn> <20210628101027.1372370-3-chenhuacai@loongson.cn> <1b42d46f-8332-204e-62d6-d0903d5a0af7@flygoat.com> From: Jiaxun Yang Message-ID: <896f834f-887b-4216-cdcc-cd5eaba6717c@flygoat.com> Date: Mon, 28 Jun 2021 18:57:26 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org 在 2021/6/28 下午6:55, Huacai Chen 写道: > Hi, Jiaxun, > > On Mon, Jun 28, 2021 at 6:41 PM Jiaxun Yang wrote: >> >> >> 在 2021/6/28 下午6:38, Huacai Chen 写道: >>> Hi, Jiaxun, >>> >>> On Mon, Jun 28, 2021 at 6:13 PM Jiaxun Yang wrote: >>>> >>>> 在 2021/6/28 下午6:10, Huacai Chen 写道: >>>>> Loongson PCH (LS7A chipset) will be used by both MIPS-based and >>>>> LoongArch-based Loongson processors. MIPS-based Loongson uses FDT >>>>> but LoongArch-base Loongson uses ACPI, but the driver in drivers/ >>>>> pci/controller/pci-loongson.c is FDT-only. So move the quirks to >>>>> quirks.c where can be shared by all architectures. >>>>> >>>>> LoongArch is a new RISC ISA, mainline support will come soon, and >>>>> documentations are here (in translation): >>>>> >>>>> https://github.com/loongson/LoongArch-Documentation >>>> Probably you should guard it with CONFIG_MACH_LOONGSON64 now and add >>>> CONFIG_LOONGARCH >>>> once LOONGARCH code is mainlined. >>> These quirks won't match non-Loongson platforms (because they are >>> matched by pci ids), so I think that is unnecessary. >> Are you sure? >> As I saw >> +DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID >> It will slow down boot progress on all systems. > This ANY ID matching is only used by loongson_mrrs_quirk(), but the > next patch will rework loongson_mrrs_quirk(). Oh I see. That seems better. Thanks. - Jiaxun > > Huacai >