* [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN
@ 2023-02-28 4:34 Xi Ruoyao
2023-03-07 5:42 ` Ping: " Xi Ruoyao
0 siblings, 1 reply; 4+ messages in thread
From: Xi Ruoyao @ 2023-02-28 4:34 UTC (permalink / raw)
To: linux-pci
Cc: linux-kernel, Lorenzo Pieralisi, Krzysztof Wilczyński,
Rob Herring, Bjorn Helgaas, Xiaowei Song, Xi Ruoyao, stable
pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to select
REGMAP_MMIO or vmlinux fails to link with "undefined reference to
`__devm_regmap_init_mmio_clk`.
Cc: stable@vger.kernel.org # at least for 6.1 and 6.2
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
---
drivers/pci/controller/dwc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 434f6a4f4041..d29551261e80 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -307,6 +307,7 @@ config PCIE_KIRIN
tristate "HiSilicon Kirin series SoCs PCIe controllers"
depends on PCI_MSI
select PCIE_DW_HOST
+ select REGMAP_MMIO
help
Say Y here if you want PCIe controller support
on HiSilicon Kirin series SoCs.
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Ping: [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN
2023-02-28 4:34 [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN Xi Ruoyao
@ 2023-03-07 5:42 ` Xi Ruoyao
2023-03-10 10:45 ` Lorenzo Pieralisi
0 siblings, 1 reply; 4+ messages in thread
From: Xi Ruoyao @ 2023-03-07 5:42 UTC (permalink / raw)
To: linux-pci
Cc: linux-kernel, Lorenzo Pieralisi,
Krzysztof Wilczy��ski, Rob Herring, Bjorn Helgaas,
Xiaowei Song, stable
Gentle ping.
On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote:
> pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to
> select
> REGMAP_MMIO or vmlinux fails to link with "undefined reference to
> `__devm_regmap_init_mmio_clk`.
>
> Cc: stable@vger.kernel.org # at least for 6.1 and 6.2
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
> drivers/pci/controller/dwc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig
> b/drivers/pci/controller/dwc/Kconfig
> index 434f6a4f4041..d29551261e80 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -307,6 +307,7 @@ config PCIE_KIRIN
> tristate "HiSilicon Kirin series SoCs PCIe controllers"
> depends on PCI_MSI
> select PCIE_DW_HOST
> + select REGMAP_MMIO
> help
> Say Y here if you want PCIe controller support
> on HiSilicon Kirin series SoCs.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Ping: [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN
2023-03-07 5:42 ` Ping: " Xi Ruoyao
@ 2023-03-10 10:45 ` Lorenzo Pieralisi
2023-03-10 10:51 ` Xi Ruoyao
0 siblings, 1 reply; 4+ messages in thread
From: Lorenzo Pieralisi @ 2023-03-10 10:45 UTC (permalink / raw)
To: Xi Ruoyao
Cc: linux-pci, linux-kernel, Krzysztof Wilczyński, Rob Herring,
Bjorn Helgaas, Xiaowei Song, stable
On Tue, Mar 07, 2023 at 01:42:01PM +0800, Xi Ruoyao wrote:
> Gentle ping.
>
> On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote:
> > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to
> > select
> > REGMAP_MMIO or vmlinux fails to link with "undefined reference to
> > `__devm_regmap_init_mmio_clk`.
> >
> > Cc: stable@vger.kernel.org # at least for 6.1 and 6.2
I merged this (with a rewritten commit log, Fixes tag and
CC stable - please have a look and check how this has to
be written for future submissions):
https://lore.kernel.org/linux-pci/167844411812.1209684.12017386820985241641.b4-ty@kernel.org
This patch is dropped.
Thanks,
Lorenzo
> > Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> > ---
> > drivers/pci/controller/dwc/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/Kconfig
> > b/drivers/pci/controller/dwc/Kconfig
> > index 434f6a4f4041..d29551261e80 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -307,6 +307,7 @@ config PCIE_KIRIN
> > tristate "HiSilicon Kirin series SoCs PCIe controllers"
> > depends on PCI_MSI
> > select PCIE_DW_HOST
> > + select REGMAP_MMIO
> > help
> > Say Y here if you want PCIe controller support
> > on HiSilicon Kirin series SoCs.
>
> --
> Xi Ruoyao <xry111@xry111.site>
> School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Ping: [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN
2023-03-10 10:45 ` Lorenzo Pieralisi
@ 2023-03-10 10:51 ` Xi Ruoyao
0 siblings, 0 replies; 4+ messages in thread
From: Xi Ruoyao @ 2023-03-10 10:51 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: linux-pci, linux-kernel, Krzysztof Wilczy��ski,
Rob Herring, Bjorn Helgaas, Xiaowei Song, stable
On Fri, 2023-03-10 at 11:45 +0100, Lorenzo Pieralisi wrote:
> On Tue, Mar 07, 2023 at 01:42:01PM +0800, Xi Ruoyao wrote:
> > Gentle ping.
> >
> > On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote:
> > > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to
> > > select
> > > REGMAP_MMIO or vmlinux fails to link with "undefined reference to
> > > `__devm_regmap_init_mmio_clk`.
> > >
> > > Cc: stable@vger.kernel.org # at least for 6.1 and 6.2
>
> I merged this (with a rewritten commit log, Fixes tag and
> CC stable - please have a look and check how this has to
> be written for future submissions):
>
> https://lore.kernel.org/linux-pci/167844411812.1209684.12017386820985241641.b4-ty@kernel.org
>
> This patch is dropped.
Oh, didn't noticed someone has already done this in 2022 :).
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-10 11:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-28 4:34 [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN Xi Ruoyao
2023-03-07 5:42 ` Ping: " Xi Ruoyao
2023-03-10 10:45 ` Lorenzo Pieralisi
2023-03-10 10:51 ` Xi Ruoyao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).