From: Kishon Vijay Abraham I <kishon@ti.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <nsekhar@ti.com>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] PCI: endpoint: Use EPC's device in dma_alloc_coherent/dma_free_coherent
Date: Thu, 11 Jan 2018 14:01:57 +0530 [thread overview]
Message-ID: <8af4c0ae-e132-e56c-7e07-bbe4b78265bd@ti.com> (raw)
In-Reply-To: <20180110111130.GA27463@red-moon>
On Wednesday 10 January 2018 04:41 PM, Lorenzo Pieralisi wrote:
> On Tue, Dec 19, 2017 at 02:06:27PM +0530, Kishon Vijay Abraham I wrote:
>> After commit 723288836628bc1c08 ("of: restrict DMA configuration"),
>> of_dma_configure doesn't configure the coherent_dma_mask/dma_mask
>> of endpoint function device (since it doesn't have a dt node associated
>> with and hence no dma-ranges property), resulting in dma_alloc_coherent
>> (used in pci_epf_alloc_space) to fail.
>>
>> Fix it by making dma_alloc_coherent use EPC's device for allocating
>> memory address as per discussion in [1]
>>
>> [1] https://lkml.org/lkml/2017/10/24/26
>
> Hi Kishon,
>
> small nit, mind embedding the link [1] above in a lkml redirector
> format - as described in:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v4.15-rc7
>
> put it in a Link: tag to be added below - I think that's important
> for the commit log to have.
>
> Either send me the formatted link or send a v3 with it, I will merge
> then.
sure, sent you a v3.
Thanks
Kishon
prev parent reply other threads:[~2018-01-11 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 8:36 [PATCH v2] PCI: endpoint: Use EPC's device in dma_alloc_coherent/dma_free_coherent Kishon Vijay Abraham I
2018-01-09 12:40 ` Niklas Cassel
2018-01-09 12:46 ` Robin Murphy
2018-01-10 11:11 ` Lorenzo Pieralisi
2018-01-11 8:31 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8af4c0ae-e132-e56c-7e07-bbe4b78265bd@ti.com \
--to=kishon@ti.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsekhar@ti.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox