From: Shawn Lin <shawn.lin@rock-chips.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: shawn.lin@rock-chips.com, Wenrui Li <wenrui.li@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/2] PCI: rockchip: Cleanup
Date: Thu, 13 Oct 2016 09:32:10 +0800 [thread overview]
Message-ID: <8b4f18cd-bced-6779-7988-574b14a42dce@rock-chips.com> (raw)
In-Reply-To: <20161012160240.GG4308@localhost>
Hi Bjorn,
On 2016/10/13 0:02, Bjorn Helgaas wrote:
> On Wed, Oct 12, 2016 at 08:04:16AM -0500, Bjorn Helgaas wrote:
>> - Remove platform drvdata because it appears unused (we called
>> platform_set_drvdata() but not platform_get_drvdata()).
>>
>> Nothing here should change the behavior of the driver.
>>
>> Changes from v1:
>> Added Dan's indentation fix.
>> I dropped the following patches because they were a lot of churn for
>> questionable benefit:
>> PCI: rockchip: Rename accessors
>> PCI: rockchip: Swap order of rockchip_writel() reg/val arguments
>>
>> ---
>>
>> Bjorn Helgaas (1):
>> PCI: rockchip: Remove unused platform data
>>
>> Dan Carpenter (1):
>> PCI: rockchip: Indent "if" statement body
>
> I applied these to pci/host-rockchip for v4.9. I hope to ask Linus to
> pull them tomorrow, so if you see any issues, let me know soon.
Seems the first round of cleanup for host-rockchip again v10 when this
driver got merged was incorrectly changed. The issue wasn't exposed as
it's just a debug log which was easily overlooked.
So could you pick the patch[0] to fix this problem ? :)
[0]: https://patchwork.kernel.org/patch/9374129/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best Regards
Shawn Lin
prev parent reply other threads:[~2016-10-13 1:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 13:04 [PATCH v2 0/2] PCI: rockchip: Cleanup Bjorn Helgaas
2016-10-12 13:04 ` [PATCH v2 1/2] PCI: rockchip: Remove unused platform data Bjorn Helgaas
2016-10-12 13:04 ` [PATCH v2 2/2] PCI: rockchip: Indent "if" statement body Bjorn Helgaas
2016-10-12 16:02 ` [PATCH v2 0/2] PCI: rockchip: Cleanup Bjorn Helgaas
2016-10-13 1:32 ` Shawn Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4f18cd-bced-6779-7988-574b14a42dce@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wenrui.li@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox