From: Sinan Kaya <okaya@codeaurora.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: ryan@finnie.org, Gabriele Paoloni <gabriele.paoloni@huawei.com>,
Frederick Lawler <fred@fredlawl.com>,
linux-pci@vger.kernel.org, timur@codeaurora.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
open list <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
Dongdong Liu <liudongdong3@huawei.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI/portdrv: do not disable device on remove()
Date: Tue, 22 May 2018 22:40:16 -0400 [thread overview]
Message-ID: <8c91a923-1a3a-55fb-e812-62dd69d99975@codeaurora.org> (raw)
In-Reply-To: <20180523022431.GA15069@wunner.de>
On 5/22/2018 10:24 PM, Lukas Wunner wrote:
> On Tue, May 22, 2018 at 01:58:00PM -0400, Sinan Kaya wrote:
>> --- a/drivers/pci/pcie/portdrv_core.c
>> +++ b/drivers/pci/pcie/portdrv_core.c
>> @@ -409,7 +409,6 @@ void pcie_port_device_remove(struct pci_dev *dev)
>> {
>> device_for_each_child(&dev->dev, NULL, remove_iter);
>> pci_free_irq_vectors(dev);
>> - pci_disable_device(dev);
>> }
>
> Shutdown aside, pci_disable_device() is also not called in the ->remove
> path with this patch, right? Seems wrong. E.g. when unbinding the driver
> from the root port device, or when unplugging a port (happens all the time
> with Thunderbolt).
Agreed. I'll spin another version where I skip disable on shutdown path only.
>
> Thanks,
>
> Lukas
>
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-05-23 2:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 17:58 [PATCH] PCI/portdrv: do not disable device on remove() Sinan Kaya
2018-05-22 19:55 ` Ryan Finnie
2018-05-23 2:24 ` Lukas Wunner
2018-05-23 2:40 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c91a923-1a3a-55fb-e812-62dd69d99975@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=gabriele.paoloni@huawei.com \
--cc=keith.busch@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=lukas@wunner.de \
--cc=rafael.j.wysocki@intel.com \
--cc=ryan@finnie.org \
--cc=stable@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).