From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADDB523314B; Fri, 19 Dec 2025 10:38:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766140738; cv=none; b=C6YwDeuYwx6VVQm8pNmV0rwhA9WP7vyyCK8jqQyxPaROsT+SKHKgXKoghD5pAAJiOJG5EICQxtmj1kOG8Qc1oCQyDXQylktjFOiO65klWoLRFpWK/jYRRUstAxDw9Jk1Nf0ft9cJHnDCyMhtPTSi9kuyykbdy+bHva1vvUglSW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766140738; c=relaxed/simple; bh=JojbryuXzuZwBViUbKuSYpD99u7Ev05B8Sqdbjq3JeA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W2MfcGGvoVepdwqVvrYyesiYdntRLVv7Jzs1rXVT5jl0H27TShF32r/3Z+wTRW7SW7EKnRJP9fYEA+dzkHS27UyHKWrOokpnwTniLBizfhXPay3KwY+Pw02UQD55bAk3+yNc4SJhWP0HYguf9xTikQcrUIWaGVxlIxZ/kx2uIAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RTyqXLh+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RTyqXLh+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28A87C4CEF1; Fri, 19 Dec 2025 10:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766140738; bh=JojbryuXzuZwBViUbKuSYpD99u7Ev05B8Sqdbjq3JeA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RTyqXLh+pnMEDRL7QCn4ZVL5I48+KSFBkbfWLELWPIeGp5NlOGtMixn93HSyIUib1 VsXEFv6pp43x4ac+Ik1lR16wRZoTgERZyNybDBDrEdsksBKON8ZwHK+UjmvsqQ25Up NicNvwtPw0uXTVVnF0tvXLWxU5N3EIikmt2XlOs9WCGgKeBy8C+XM1a4f21WmaW1HL kzCa3N6gEjcuqriwV5jf2V1IrftSL6eodz2qshTNJlzsNkvBQ5/UsbP/PLEv2/8tA7 EOzMcZBtd8f5GjqLWa87NigJQdEnNa79jA6TIcgqP3qKIinOEECXzZvvyhNjrmtPrq cgX4J/3C22GhA== Message-ID: <8d4ae6b3-096a-4e12-8fa8-abaad2e953ad@kernel.org> Date: Fri, 19 Dec 2025 19:38:53 +0900 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] nvmet: pci-epf: Remove unnecessary dmaengine_terminate_sync() on each DMA transfer To: Frank Li , Vinod Koul , Manivannan Sadhasivam , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Koichiro Den , Niklas Cassel Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev References: <20251218-dma_prep_config-v2-0-c07079836128@nxp.com> <20251218-dma_prep_config-v2-5-c07079836128@nxp.com> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20251218-dma_prep_config-v2-5-c07079836128@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/19/25 00:56, Frank Li wrote: > dmaengine_terminate_sync() cancels all pending requests. Calling it for > every DMA transfer is unnecessary and counterproductive. This function is > generally intended for cleanup paths such as module removal, device close, > or unbind operations. > > Remove the redundant calls for success path and keep it only at error path. > > Tested-by: Niklas Cassel > Signed-off-by: Frank Li Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research