From: Shuai Xue <xueshuai@linux.alibaba.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
chengyou@linux.alibaba.com, kaishen@linux.alibaba.com,
yangyicong@huawei.com, will@kernel.org,
baolin.wang@linux.alibaba.com, robin.murphy@arm.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
rdunlap@infradead.org, mark.rutland@arm.com,
zhuo.song@linux.alibaba.com, renyu.zj@linux.alibaba.com
Subject: Re: [PATCH v7 3/4] drivers/perf: add DesignWare PCIe PMU driver
Date: Fri, 13 Oct 2023 18:45:07 +0800 [thread overview]
Message-ID: <8e373bfc-3fa4-6de3-4994-b93f78699e2f@linux.alibaba.com> (raw)
In-Reply-To: <20231013094113.00003d72@Huawei.com>
On 2023/10/13 16:41, Jonathan Cameron wrote:
>
>>>
>>>> + depends on (ARM64 && PCI)
>>>
>>> I don't see any actual ARM64 dependency in the code, so maybe omit
>>> ARM64 (as PCIE_DW_PLAT_HOST does) or add "|| COMPILE_TEST"?
>>
>> I will remove the ARM64 dependency and add COMPILE_TEST.
> don't do both. That makes no sense. either
>
> depends on PCI && (ARM64 || COMPILE_TEST)
> or
> depends on PCI
Got it.
Thank you.
Best Regards,
Shuai
next prev parent reply other threads:[~2023-10-13 10:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 3:28 [PATCH v7 0/4] drivers/perf: add Synopsys DesignWare PCIe PMU driver support Shuai Xue
2023-10-12 3:28 ` [PATCH v7 1/4] docs: perf: Add description for Synopsys DesignWare PCIe PMU driver Shuai Xue
2023-10-12 3:28 ` [PATCH v7 2/4] PCI: Add Alibaba Vendor ID to linux/pci_ids.h Shuai Xue
2023-10-12 14:59 ` Bjorn Helgaas
2023-10-12 15:27 ` Bjorn Helgaas
2023-10-13 1:07 ` Shuai Xue
2023-10-12 3:28 ` [PATCH v7 3/4] drivers/perf: add DesignWare PCIe PMU driver Shuai Xue
2023-10-12 16:25 ` Bjorn Helgaas
2023-10-13 3:46 ` Shuai Xue
2023-10-13 8:41 ` Jonathan Cameron
2023-10-13 10:45 ` Shuai Xue [this message]
2023-10-13 16:30 ` Bjorn Helgaas
2023-10-16 3:00 ` Shuai Xue
2023-10-16 14:38 ` Bjorn Helgaas
2023-10-17 0:48 ` Shuai Xue
2023-10-12 3:28 ` [PATCH v7 4/4] MAINTAINERS: add maintainers for " Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e373bfc-3fa4-6de3-4994-b93f78699e2f@linux.alibaba.com \
--to=xueshuai@linux.alibaba.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=chengyou@linux.alibaba.com \
--cc=helgaas@kernel.org \
--cc=kaishen@linux.alibaba.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rdunlap@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yangyicong@huawei.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox