linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: Wang Lu <wanglu@dapustor.com>, bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/P2PDMA: fix the wrong dma address calculation when map sg
Date: Thu, 9 Sep 2021 10:51:07 -0600	[thread overview]
Message-ID: <8e3b718c-1a74-232c-0e4c-9cc76d3ae1ac@deltatee.com> (raw)
In-Reply-To: <20210909032528.24517-1-wanglu@dapustor.com>




On 2021-09-08 9:25 p.m., Wang Lu wrote:
> The bus offset is bus address - physical address,
> so the calculation in __pci_p2pdma_map_sg should be:
> bus address = physical address + bus offset.
> 
> Signed-off-by: Wang Lu <wanglu@dapustor.com>

Thanks, yes I believe my math was wrong here.

It was never tested on any machine that has a non-zero bus-offset.

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

  reply	other threads:[~2021-09-09 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  3:25 [PATCH] PCI/P2PDMA: fix the wrong dma address calculation when map sg Wang Lu
2021-09-09 16:51 ` Logan Gunthorpe [this message]
2021-09-09 17:28 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e3b718c-1a74-232c-0e4c-9cc76d3ae1ac@deltatee.com \
    --to=logang@deltatee.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=wanglu@dapustor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).