From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.li@nxp.com>, Rob Herring <robh@kernel.org>
Cc: bhelgaas@google.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, festevam@gmail.com,
helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev,
kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
kw@linux.com, l.stach@pengutronix.de,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org,
s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v3 08/13] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string
Date: Wed, 13 Dec 2023 07:28:07 +0100 [thread overview]
Message-ID: <8ea476e0-e026-4599-a5d5-66a499a1f422@linaro.org> (raw)
In-Reply-To: <ZXjsq2QtFa2V0BAl@lizhi-Precision-Tower-5810>
On 13/12/2023 00:28, Frank Li wrote:
>>> items:
>>> @@ -90,6 +91,22 @@ required:
>>> allOf:
>>> - $ref: /schemas/pci/snps,dw-pcie.yaml#
>>> - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml#
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + enum:
>>> + - fsl,imx95-pcie
>>> + then:
>>> + properties:
>>> + reg:
>>> + minItems: 4
>>> + reg-names:
>>> + items:
>>> + - const: dbi
>>> + - const: serdes
>>
>> Did you test this? It should fail because 'serdes' would need to be
>> added to snps,dw-pcie.yaml.
>
> I run "make dt_binding_check DT_SCHEMA_FILES=/pci/", no error report.
> And PCIe function can work.
Did you test your DTS. The answer is, like Rob suspected: no, you did
not test it.
This fails.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-13 6:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 21:58 [PATCH v3 00/13] PCI: imx6: Clean up and add imx95 pci support Frank Li
2023-12-11 21:58 ` [PATCH v3 01/13] PCI: imx6: Simplify clock handling by using HAS_CLK_* bitmask Frank Li
2023-12-12 16:49 ` Manivannan Sadhasivam
2023-12-12 18:32 ` Frank Li
2023-12-12 22:54 ` Rob Herring
2023-12-12 23:18 ` Frank Li
2023-12-11 21:58 ` [PATCH v3 02/13] PCI: imx6: Simplify phy handling by using by using IMX6_PCIE_FLAG_HAS_PHY Frank Li
2023-12-11 21:58 ` [PATCH v3 03/13] PCI: imx6: Simplify reset handling by using by using *_FLAG_HAS_*_RESET Frank Li
2023-12-11 21:58 ` [PATCH v3 04/13] PCI: imx6: Using "linux,pci-domain" as slot ID Frank Li
2023-12-11 21:58 ` [PATCH v3 05/13] PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask Frank Li
2023-12-11 21:58 ` [PATCH v3 06/13] PCI: imx6: Simplify configure_type() by using mode_off and mode_mask Frank Li
2023-12-11 21:58 ` [PATCH v3 07/13] PCI: imx6: Simplify switch-case logic by involve init_phy callback Frank Li
2023-12-11 21:58 ` [PATCH v3 08/13] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string Frank Li
2023-12-12 22:44 ` Rob Herring
2023-12-12 23:28 ` Frank Li
2023-12-13 6:28 ` Krzysztof Kozlowski [this message]
2023-12-13 14:36 ` Rob Herring
2023-12-13 15:39 ` Frank Li
2023-12-13 16:46 ` Frank Li
2023-12-11 21:58 ` [PATCH v3 09/13] PCI: imx6: Add iMX95 PCIe support Frank Li
2023-12-11 21:58 ` [PATCH v3 10/13] PCI: imx6: Clean up get addr_space code Frank Li
2023-12-11 21:58 ` [PATCH v3 11/13] PCI: imx6: Add epc_features in imx6_pcie_drvdata Frank Li
2023-12-11 21:58 ` [PATCH v3 12/13] dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string Frank Li
2023-12-12 16:51 ` Conor Dooley
2023-12-13 6:29 ` Krzysztof Kozlowski
2023-12-11 21:58 ` [PATCH v3 13/13] PCI: imx6: Add iMX95 Endpoint (EP) function support Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea476e0-e026-4599-a5d5-66a499a1f422@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox