From: Juergen Gross <jgross@suse.com>
To: Wentao Liang <vulab@iscas.ac.cn>, bhelgaas@google.com
Cc: boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, oleksandr_tyshchenko@epam.com,
sstabellini@kernel.org, u.kleine-koenig@pengutronix.de,
xen-devel@lists.xenproject.org, stable@vger.kernel.org
Subject: Re: [PATCH] xen/pcifront: Fix PCI device reference leak in pcifront_common_process()
Date: Fri, 9 Oct 2026 10:23:34 +0200 [thread overview]
Message-ID: <90cc2e5c-8e45-46bb-8a06-d80be43cb36c@suse.com> (raw)
In-Reply-To: <20260917132944.2153421-1-vulab@iscas.ac.cn>
[-- Attachment #1.1.1: Type: text/plain, Size: 719 bytes --]
On 17.09.26 15:29, Wentao Liang wrote:
> pcifront_common_process() gets a reference to the PCI device with
> pci_get_domain_bus_and_slot() and only drops it on the early error
> path. Returning directly from the AER handler switch instead of
> recording the result and falling through to the common
> pci_dev_put(pcidev) leaks the reference on every successful call.
>
> Collect the handler result in a variable and drop the reference on the
> single exit path again.
>
> Fixes: 34ab316d7287 ("xen/pcifront: Drop pcifront_common_process() tests of pcidev, pdrv")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2026-10-09 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 13:29 [PATCH] xen/pcifront: Fix PCI device reference leak in pcifront_common_process() Wentao Liang
2026-09-17 13:35 ` sashiko-bot
2026-10-09 8:23 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90cc2e5c-8e45-46bb-8a06-d80be43cb36c@suse.com \
--to=jgross@suse.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vulab@iscas.ac.cn \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox