Re: [PATCH v5 2/3] PCI: exynos: Switch to devm_clk_bulk_get_all_enabled()

Cristian Ciocaltea
2024-12-23T15:03:44Z

On 12/23/24 4:18 PM, Krzysztof Wilczyński wrote:
> Hello,
>
>>> The helper devm_clk_bulk_get_all_enable() missed to return the number of
>>> clocks stored in the clk_bulk_data table referenced by the clks
>>> argument and, therefore, will be dropped.
>>>
>>> Use the newly introduced devm_clk_bulk_get_all_enabled() variant
>>> instead, which is consistent with devm_clk_bulk_get_all() in terms of
>>> the returned value:
>>>
>>> > 0 if one or more clocks have been stored
>>> = 0 if there are no clocks
>>> < 0 if an error occurred
>>>
>>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>
>> In case you missed the previous requests, we need your ack on this patch
>> so that Stephen can apply the entire series to the clk tree and drop the
>> obsolete helper.
>
> Please, take the following:
>
> Acked-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
>
> Should be sufficient.
>
> Also, sorry for keeping you both waiting.

Thanks Krzysztof, no worries!

Regards,
Cristian