From: Mario Limonciello <mario.limonciello@amd.com>
To: Jihong Min <hurryman2212@icloud.com>,
Jihong Min <hurryman2212@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
linux-usb@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] usb: xhci-pci: add AMD Promontory 21 PCI glue
Date: Fri, 8 May 2026 12:42:04 -0500 [thread overview]
Message-ID: <966c9e07-10e6-4abe-9cb5-77b974f31302@amd.com> (raw)
In-Reply-To: <0d518d40-e239-4d93-8e71-0d2e140f00ca@icloud.com>
On 5/8/26 12:39, Jihong Min wrote:
> > This define should be in a common header used by xhci-pci.c and
> > xhci-pci-prom21.c both.
>
> Agreed. I moved PCI_DEVICE_ID_AMD_PROM21_XHCI to xhci-pci.h so both
> xhci-pci.c and xhci-pci-prom21.c use the same definition.
>
> Sincerely,
> Jihong Min
>
Something else I was thinking about while reviewing this series.
Promontory 21 is only on AMD platforms and AMD platforms are only x86.
I think the Kconfig should be conditional on AMD CPU support being
enabled and X86 architecture so that we don't bloat other architectures
with dead code that will never run.
next prev parent reply other threads:[~2026-05-08 17:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 14:39 [PATCH v4 0/2] AMD Promontory 21 xHCI temperature sensor support Jihong Min
2026-05-08 14:39 ` [PATCH v4 1/2] usb: xhci-pci: add AMD Promontory 21 PCI glue Jihong Min
2026-05-08 16:40 ` Mario Limonciello
2026-05-08 17:39 ` Jihong Min
2026-05-08 17:42 ` Mario Limonciello [this message]
2026-05-08 17:48 ` Jihong Min
2026-05-08 18:11 ` Jihong Min
2026-05-08 18:15 ` Guenter Roeck
2026-05-08 18:39 ` Jihong Min
2026-05-09 5:34 ` Jihong Min
2026-05-09 5:52 ` Mario Limonciello
2026-05-09 6:54 ` Jihong Min
2026-05-08 14:39 ` [PATCH v4 2/2] hwmon: add AMD Promontory 21 xHCI temperature sensor support Jihong Min
2026-05-08 15:45 ` Guenter Roeck
2026-05-08 17:37 ` Jihong Min
2026-05-08 16:51 ` Mario Limonciello
2026-05-08 17:40 ` Jihong Min
2026-05-08 21:52 ` sashiko-bot
2026-05-09 5:18 ` Jihong Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=966c9e07-10e6-4abe-9cb5-77b974f31302@amd.com \
--to=mario.limonciello@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hurryman2212@gmail.com \
--cc=hurryman2212@icloud.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathias.nyman@intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox