From: Heiner Kallweit <hkallweit1@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH 0/2] PCI: Add and use pcim_iomap_region()
Date: Wed, 27 Mar 2024 12:52:06 +0100 [thread overview]
Message-ID: <982b02cb-a095-4131-84a7-24817ac68857@gmail.com> (raw)
Several drivers use the following sequence for a single BAR:
rc = pcim_iomap_regions(pdev, BIT(bar), name);
if (rc)
error;
addr = pcim_iomap_table(pdev)[bar];
Let's create a simpler (from implementation and usage perspective)
pcim_iomap_region() for this use case.
Note: The check for !pci_resource_len() is included in
pcim_iomap(), so we don't have to duplicate it.
Make r8169 the first user of the new function.
I'd prefer to handle this via the PCI tree.
Heiner Kallweit (2):
PCI: Add pcim_iomap_region
r8169: use new function pcim_iomap_region()
drivers/net/ethernet/realtek/r8169_main.c | 8 +++----
drivers/pci/devres.c | 28 +++++++++++++++++++++++
include/linux/pci.h | 2 ++
3 files changed, 33 insertions(+), 5 deletions(-)
--
2.44.0
next reply other threads:[~2024-03-27 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 11:52 Heiner Kallweit [this message]
2024-03-27 11:53 ` [PATCH 1/2] PCI: Add pcim_iomap_region Heiner Kallweit
2024-03-27 11:54 ` [PATCH 2/2] r8169: use new function pcim_iomap_region() Heiner Kallweit
2024-03-27 13:35 ` Philipp Stanner
2024-03-27 13:20 ` [PATCH 0/2] PCI: Add and use pcim_iomap_region() Philipp Stanner
2024-03-28 17:35 ` Heiner Kallweit
2024-03-28 22:03 ` Heiner Kallweit
2024-04-02 13:17 ` Philipp Stanner
2024-04-02 13:54 ` Heiner Kallweit
2024-04-02 14:11 ` Philipp Stanner
2024-04-02 19:06 ` Heiner Kallweit
2024-04-02 13:40 ` Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=982b02cb-a095-4131-84a7-24817ac68857@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox