From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.11.231]:42870 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756143AbaE2PEB convert rfc822-to-8bit (ORCPT ); Thu, 29 May 2014 11:04:01 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: [PATCH v2 03/18] PCI: designware: Configuration space should be specified in 'reg' From: Kumar Gala In-Reply-To: <1401345500-20188-4-git-send-email-kishon@ti.com> Date: Thu, 29 May 2014 10:03:54 -0500 Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Vasut , arnd@arndb.de, tony@atomide.com, Mohit Kumar , jg1.han@samsung.com, Jason Gunthorpe , Bjorn Helgaas Message-Id: <98E18225-3C63-4106-901A-A5D3DEC268C8@codeaurora.org> References: <1401345500-20188-1-git-send-email-kishon@ti.com> <1401345500-20188-4-git-send-email-kishon@ti.com> To: Kishon Vijay Abraham I Sender: linux-pci-owner@vger.kernel.org List-ID: On May 29, 2014, at 1:38 AM, Kishon Vijay Abraham I wrote: > The configuration address space has so far been specified in *ranges*, > however it should be specified in *reg* making it a platform MEM resource. > Hence used 'platform_get_resource_*' API to get configuration address > space in the designware driver. > > Cc: Jason Gunthorpe > Cc: Bjorn Helgaas > Cc: Mohit Kumar > Cc: Jingoo Han > Cc: Marek Vasut > Cc: Arnd Bergmann > Signed-off-by: Kishon Vijay Abraham I > --- > .../devicetree/bindings/pci/designware-pcie.txt | 1 + > drivers/pci/host/pcie-designware.c | 17 +++++++++++++++-- > 2 files changed, 16 insertions(+), 2 deletions(-) Why should the cfg space be defined in *reg* instead of ranges? - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation