From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-acpi@vger.kernel.org, rjw@rjwysocki.net,
bhelgaas@google.com, ravikanth.nalla@hpe.com,
linux@rainbow-software.org, timur@codeaurora.org,
cov@codeaurora.org, jcm@redhat.com, alex.williamson@redhat.com,
linux-pci@vger.kernel.org, agross@codeaurora.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
wim@djo.tudelft.nl, linux-arm-kernel@lists.infradead.org,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages
Date: Sun, 23 Oct 2016 23:22:02 -0400 [thread overview]
Message-ID: <98bb7d24-94db-b585-918e-04f3a64d93f0@codeaurora.org> (raw)
In-Reply-To: <20161021013930.GB31044@localhost>
On 10/20/2016 9:39 PM, Bjorn Helgaas wrote:
>> These API need to bypass the acpi_irq_get_penalty function.
> I don't mind this patch, but the changelog doesn't tell me what's
> broken and why we need this fix. Apparently acpi_irq_get_penalty()
> doesn't work before ACPI is initialized, but I don't see *why* it
> wouldn't work.
I'll update the commit message as you suggested. The code doesn't work
if we apply PATCH V4 2/3 + PATCH V4 3/3 without PATCH V4 1/3 since
the caller is going to end up calling get_penalty function while ACPI
is not initialized. This happened during the debug of this regression.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-10-24 3:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 22:21 [PATCH V4 0/3] ACPI, PCI, IRQ: revert penalty calculation for ISA and SCI interrupts Sinan Kaya
2016-10-19 22:21 ` [PATCH V4 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages Sinan Kaya
2016-10-20 21:39 ` Rafael J. Wysocki
2016-10-24 3:48 ` Sinan Kaya
2016-10-21 1:39 ` Bjorn Helgaas
2016-10-21 14:07 ` Bjorn Helgaas
2016-10-24 3:22 ` Sinan Kaya [this message]
2016-10-23 3:48 ` [V4, " Jonathan Liu
2016-10-24 4:17 ` Sinan Kaya
2016-10-24 4:21 ` Jonathan Liu
2016-10-19 22:21 ` [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function" Sinan Kaya
2016-10-21 1:58 ` Bjorn Helgaas
2016-10-21 14:45 ` Bjorn Helgaas
2016-10-21 16:13 ` Sinan Kaya
2016-10-22 14:57 ` Bjorn Helgaas
2016-10-24 3:48 ` Sinan Kaya
2016-10-22 23:28 ` Bjorn Helgaas
2016-10-24 3:48 ` Sinan Kaya
2016-10-23 3:49 ` [V4,2/3] " Jonathan Liu
2016-10-19 22:21 ` [PATCH V4 3/3] Revert "ACPI, PCI, IRQ: separate ISA penalty calculation" Sinan Kaya
2016-10-21 2:31 ` Bjorn Helgaas
2016-10-21 2:58 ` Sinan Kaya
2016-10-22 23:59 ` Bjorn Helgaas
2016-10-24 4:16 ` Sinan Kaya
2016-10-23 3:49 ` [V4,3/3] Revert "ACPI,PCI,IRQ: " Jonathan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98bb7d24-94db-b585-918e-04f3a64d93f0@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=cov@codeaurora.org \
--cc=helgaas@kernel.org \
--cc=jcm@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=ravikanth.nalla@hpe.com \
--cc=rjw@rjwysocki.net \
--cc=timur@codeaurora.org \
--cc=wim@djo.tudelft.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).