From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38FD4C3A5A7 for ; Tue, 6 Dec 2022 19:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbiLFT1g (ORCPT ); Tue, 6 Dec 2022 14:27:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbiLFT12 (ORCPT ); Tue, 6 Dec 2022 14:27:28 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8639A22BFD for ; Tue, 6 Dec 2022 11:26:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670354785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dr9eadMAbHe85PAKzK4dCl/lg7DFQYZXZiHsTAGln3s=; b=R2fI0IXVg0UZbmUskEkn2FadBVHJK7rhxNSQ7cHZ1EEVur8oh77KUyA207QPVwLCGp/rcW 4E2NzlgKGSu+pHWsuN74XCEYxQUctf1L2DpxIXsYTzgmCpmfnnnvy3i3K20Adyng7Jk0j9 v9WIn/daz8ecImREGAw3cypMHf0oUcE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-272-0YNrdX_ZPUW2OGS5ROi6tQ-1; Tue, 06 Dec 2022 14:26:24 -0500 X-MC-Unique: 0YNrdX_ZPUW2OGS5ROi6tQ-1 Received: by mail-ej1-f70.google.com with SMTP id hq42-20020a1709073f2a00b007c100387d64so2070889ejc.3 for ; Tue, 06 Dec 2022 11:26:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dr9eadMAbHe85PAKzK4dCl/lg7DFQYZXZiHsTAGln3s=; b=SaXkxuvvfup+r4paf0kKv5r8+2Mjkgbhrr9/DWfwCaH7S9+FHJV8vKpwX+XAuq00QA SjMFL5Ahcck2FK2GqwK8JbnjIH+JrJ+V1ta9JKGDLIstr4qtmnGkQ6w1J8JgnfFE6uDq dzW2JyQ/0R7WxbgZX3Ig9Vzhp8opmBVQ5/RDfKP/74Nj+IW2jrutmHDSgDhHevlU1zaO G8KbrxwLpsuSDsgmra+g2bE8E1XEJdJclhwv6BTzOOmiK4iaFhsp3fDN2QTOcTJIW5tF zHvCGzkcGu6hyryeRYlK9xsTDJdvewcd4y9i4CJE6R1LQpa0hUczAFSIZZTjTea138+q qraQ== X-Gm-Message-State: ANoB5pmbgVbG0ELIzgZL0LU+a6iwoknL2FdLA95ATC+N3WRCzQqCH4ry QdCpH8dy7mLotsNB0pbMCWu2uBdopT0DmAEYTOGIfPIw7LGpxkSdPVoliwme6UK9IEvXIWqjbc9 rviSoH0q4Gj4Y8PaVGO4i X-Received: by 2002:aa7:c2cf:0:b0:46d:1c24:e804 with SMTP id m15-20020aa7c2cf000000b0046d1c24e804mr3304313edp.221.1670354783212; Tue, 06 Dec 2022 11:26:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5ZnYXnvfbGNrTKHhGwrdtvgNBxij/xgDDLq8t20iByjVwRgYRuPK862mYTmRsalvyG5aoJlw== X-Received: by 2002:aa7:c2cf:0:b0:46d:1c24:e804 with SMTP id m15-20020aa7c2cf000000b0046d1c24e804mr3304302edp.221.1670354783046; Tue, 06 Dec 2022 11:26:23 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id sb25-20020a1709076d9900b007ba46867e6asm7781934ejc.16.2022.12.06.11.26.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 11:26:22 -0800 (PST) Message-ID: <9bc9cd5f-cfbe-f997-bd97-2ec874853d93@redhat.com> Date: Tue, 6 Dec 2022 20:26:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/PCI: Disable E820 reserved region clipping for Clevo NL4XLU laptops Content-Language: en-US, nl To: Bjorn Helgaas Cc: Bjorn Helgaas , linuxkernelml@undead.fr, Florent DELAHAYE , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org References: <20221206172604.GA1356368@bhelgaas> From: Hans de Goede In-Reply-To: <20221206172604.GA1356368@bhelgaas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Bjorn, On 12/6/22 18:26, Bjorn Helgaas wrote: > On Sun, Dec 04, 2022 at 10:42:38AM +0100, Hans de Goede wrote: >> On 12/2/22 22:58, Bjorn Helgaas wrote: >>> On Wed, Oct 12, 2022 at 10:23:12AM +0200, Hans de Goede wrote: >>>> On 10/11/22 19:40, Bjorn Helgaas wrote: >>>>> On Mon, Oct 10, 2022 at 05:02:06PM +0200, Hans de Goede wrote: >>>>>> Clevo NL4XLU barebones have the same E820 reservation covering >>>>>> the entire _CRS 32-bit window issue as the Lenovo *IIL* and >>>>>> Clevo X170KM-G models, relevant dmesg bits (with pci=no_e820): >>>>>> ... >>>>>> Add a no_e820 quirk for these models to fix the touchpad not working >>>>>> (due to Linux being unable to assign a PCI BAR for the i2c-controller). >> ... > >> As I mentioned in the email-thread about that patch-series (and there >> now is dmesg E820 output to confirm this) your generic fix will >> unfortunately only work when people boot in EFI mode. It will still >> be good to have the generic fix of course. >> >> But maybe we should also add this quirk to make sure these >> Clevo-s also work properly when booted in BIOS CSM mode ? > > Yes, if they can boot in CSM mode, we should probably add the quirk. > But Florent doesn't see a way to boot his Clevo NL41LU2/NL4XLU in CSM > mode, so I think we can postpone adding the quirk until we find a > machine where it makes a difference: Ack. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1948811/comments/8 > > I added a note to https://bugzilla.kernel.org/show_bug.cgi?id=216565 > to that effect. Thank you for also following up on this in bugzilla. Regards, Hans ' > >>>>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216565 >>>>>> Signed-off-by: Hans de Goede >>>>>> --- >>>>>> arch/x86/pci/acpi.c | 13 +++++++++++++ >>>>>> 1 file changed, 13 insertions(+) >>>>>> >>>>>> diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c >>>>>> index 2f82480fd430..45ef65d31a40 100644 >>>>>> --- a/arch/x86/pci/acpi.c >>>>>> +++ b/arch/x86/pci/acpi.c >>>>>> @@ -189,6 +189,19 @@ static const struct dmi_system_id pci_crs_quirks[] __initconst = { >>>>>> DMI_MATCH(DMI_BOARD_NAME, "X170KM-G"), >>>>>> }, >>>>>> }, >>>>>> + >>>>>> + /* >>>>>> + * Clevo NL4XLU barebones have the same E820 reservation covering >>>>>> + * the entire _CRS 32-bit window issue as the Lenovo *IIL* models. >>>>>> + * See https://bugzilla.kernel.org/show_bug.cgi?id=216565 >>>>>> + */ >>>>>> + { >>>>>> + .callback = set_no_e820, >>>>>> + .ident = "Clevo NL4XLU Barebone", >>>>>> + .matches = { >>>>>> + DMI_MATCH(DMI_BOARD_NAME, "NL4XLU"), >>>>>> + }, >>>>>> + }, >>>>>> {} >>>>>> }; >