From: Markus Elfring <Markus.Elfring@web.de>
To: Hongchen Zhang <zhanghongchen@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
linux-pci@vger.kernel.org, loongarch@lists.linux.dev,
Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] PCI: use local_pci_probe when best selected cpu is offline
Date: Wed, 12 Jun 2024 20:08:04 +0200 [thread overview]
Message-ID: <9bf241c5-68af-4471-a159-1c673243d80d@web.de> (raw)
In-Reply-To: <20240605075419.3973256-1-zhanghongchen@loongson.cn>
…
> This can be happen if a node is online while all its CPUs are offline
> (we can use "maxcpus=1" without "nr_cpus=1" to reproduce it), Therefore,
> in this case, we should call local_pci_probe() instead of work_on_cpu().
* Please take text layout concerns a bit better into account also according to
the usage of paragraphs.
https://elixir.bootlin.com/linux/v6.10-rc3/source/Documentation/process/maintainer-tip.rst#L128
* Please improve the change description with an imperative wording.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n94
* Would you like to add the tag “Fixes” accordingly?
* How do you think about to specify the name of the affected function
in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2024-06-12 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 7:54 [PATCH v2] PCI: use local_pci_probe when best selected cpu is offline Hongchen Zhang
2024-06-12 4:51 ` Huacai Chen
2024-06-12 18:08 ` Markus Elfring [this message]
2024-06-13 2:20 ` Hongchen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bf241c5-68af-4471-a159-1c673243d80d@web.de \
--to=markus.elfring@web.de \
--cc=bhelgaas@google.com \
--cc=chenhuacai@loongson.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=zhanghongchen@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox