From: Heiner Kallweit <hkallweit1@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
Martin Habets <habetsm.xilinx@gmail.com>,
Siva Reddy Kallam <siva.kallam@broadcom.com>,
Prashant Sreedharan <prashant@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 0/8] PCI/VPD: Extend PCI VPD API
Date: Fri, 20 Aug 2021 23:36:14 +0200 [thread overview]
Message-ID: <9c2e1cad-9c3e-634e-e9d7-2e08ec4825df@gmail.com> (raw)
In-Reply-To: <20210820205036.GA3356538@bjorn-Precision-5520>
On 20.08.2021 22:50, Bjorn Helgaas wrote:
> On Wed, Aug 18, 2021 at 08:58:18PM +0200, Heiner Kallweit wrote:
>> This series adds three functions to the PCI VPD API that help to
>> simplify driver code. First users are sfc and tg3 drivers because
>> I have test hw. The other users of the VPD API will benefit from a
>> migration as well.
>> I'd propose to apply this series via the PCI tree.
>>
>> Added API calls:
>>
>> pci_vpd_alloc()
>> Dynamically allocates a properly sized buffer and reads the VPD into it.
>>
>> pci_vpd_find_ro_info_keyword()
>> Locates an info field keyword in the VPD RO section.
>> pci_vpd_find_info_keyword() can be removed once all
>> users have been migrated.
>>
>> pci_vpd_check_csum()
>> Check VPD checksum based on algorithm defined in the PCI specification.
>>
>> Tested on a SFN6122F and a BCM95719 card.
>>
>> Heiner Kallweit (8):
>> PCI/VPD: Add pci_vpd_alloc
>> PCI/VPD: Add pci_vpd_find_ro_info_keyword and pci_vpd_check_csum
>> PCI/VPD: Add missing VPD RO field keywords
>> sfc: Use new function pci_vpd_alloc
>> sfc: Use new VPD API function pci_vpd_find_ro_info_keyword
>> tg3: Use new function pci_vpd_alloc
>> tg3: Use new function pci_vpd_check_csum
>> tg3: Use new function pci_vpd_find_ro_info_keyword
>>
>> drivers/net/ethernet/broadcom/tg3.c | 115 +++++++---------------------
>> drivers/net/ethernet/broadcom/tg3.h | 1 -
>> drivers/net/ethernet/sfc/efx.c | 78 +++++--------------
>> drivers/pci/vpd.c | 82 ++++++++++++++++++++
>> include/linux/pci.h | 32 ++++++++
>> 5 files changed, 163 insertions(+), 145 deletions(-)
>
> Beautiful! I applied this with minor tweaks to pci/vpd for v5.15.
>
> I dropped the "add missing keywords" patch because there are no users
> of the missing keywords yet.
>
Chelsio T4 driver is using this keyword. Then I'll add this keyword
when migrating the driver.
> I would have removed pci_vpd_find_info_keyword() as well, but it looks
> like there are stilla few users of it.
>
Right, there are few more users. In this initial series I only changed
users for which I have test hw.
prev parent reply other threads:[~2021-08-20 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 18:58 [PATCH 0/8] PCI/VPD: Extend PCI VPD API Heiner Kallweit
2021-08-18 18:59 ` [PATCH 1/8] PCI/VPD: Add pci_vpd_alloc Heiner Kallweit
2021-08-18 19:00 ` [PATCH 2/8] PCI/VPD: Add pci_vpd_find_ro_info_keyword and pci_vpd_check_csum Heiner Kallweit
2021-08-18 19:01 ` [PATCH 3/8] PCI/VPD: Add missing VPD RO field keywords Heiner Kallweit
2021-08-18 19:02 ` [PATCH 4/8] sfc: Use new function pci_vpd_alloc Heiner Kallweit
2021-08-18 19:03 ` [PATCH 5/8] sfc: Use new VPD API function pci_vpd_find_ro_info_keyword Heiner Kallweit
2021-08-18 19:04 ` [PATCH 6/8] tg3: Use new function pci_vpd_alloc Heiner Kallweit
2021-08-18 19:05 ` [PATCH 7/8] tg3: Use new function pci_vpd_check_csum Heiner Kallweit
2021-08-18 19:06 ` [PATCH 8/8] tg3: Use new function pci_vpd_find_ro_info_keyword Heiner Kallweit
2021-08-20 20:50 ` [PATCH 0/8] PCI/VPD: Extend PCI VPD API Bjorn Helgaas
2021-08-20 21:36 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c2e1cad-9c3e-634e-e9d7-2e08ec4825df@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=helgaas@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=siva.kallam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).