From: Mario Limonciello <mario.limonciello@amd.com>
To: "Christian König" <christian.koenig@amd.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Geramy Loveless <gloveless@jqluv.com>,
Bjorn Helgaas <bhelgaas@google.com>,
alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org,
nra3088@gmail.com, meiling.leung@embeddedllm.com,
linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: Reserve prefetchable window headroom for Resizable BARs
Date: Mon, 31 Aug 2026 12:55:00 -0500 [thread overview]
Message-ID: <9d2e5f9f-1713-47a2-a5c3-d6385e691d2a@amd.com> (raw)
In-Reply-To: <bb909250-14e3-4a0f-a017-44731ee0f5a1@amd.com>
On 8/31/26 12:52, Christian König wrote:
>
>
> On 8/31/26 18:58, Ilpo Järvinen wrote:
>> On Mon, 31 Aug 2026, Christian König wrote:
> ...
>>>> 2. Pack Oversized Windows (BAR Demotion):
>>>> The PCI-to-PCI Bridge spec (r1.2, sec 3.2.5) permits a prefetchable BAR
>>>> to be assigned from the non-prefetchable window. By clearing the PREFETCH
>>>> flag on small control BARs during enumeration, they are placed below 4 GiB.
>>>> The prefetchable window is then cleanly sized to the large BAR alone.
>>>
>>> Interesting hack, shouldn't really matter for AMD GPUs but that is
>>> something more on the heuristic side.
>>>
>>> A perfectly valid trick which is done by BIOS implementations but what
>>> the Linux PCI subsystem still hasn't learned are back to back
>>> allocations, e.g. something like this:
>>>
>>> BAR0 32 GiB of GPU #1
>>> BAR1 2 MiB of GPU #1
>>>
>>> BAR1 2 MiB of GPU #2
>>> BAR0 32 GiB of GPU #2
>>
>> Assuming you're oversimplifying the layout above, this was added by the commit
>> 9036bd0efcb6 ("PCI: Align head space better").
>
> Oh nice! Yeah we had quite a number of bug reports because of that.
>
> Usually hot unplugging some PCIe HW and then re-plugging it caused surprises when the BIOS assigned the resources initially and then the Linux kernel on re-plug.
>
> I need to dig up those bug reports and add a reference to the commit to let people retest.
>
That's actually "part" of why we have a behavior in thunderbolt.ko that
we do a USB4 router reset at module load.
It gives you a clean break to let the resources get assigned by the kernel.
The other part is consistency with other OSes.
next prev parent reply other threads:[~2026-08-31 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 21:37 [PATCH] PCI: Reserve prefetchable window headroom for Resizable BARs Geramy Loveless
2026-08-31 7:49 ` Christian König
2026-08-31 16:58 ` Ilpo Järvinen
2026-08-31 17:49 ` Geramy Loveless
2026-08-31 18:07 ` Christian König
2026-08-31 18:19 ` Mario Limonciello
2026-08-31 18:32 ` Ilpo Järvinen
2026-08-31 17:52 ` Christian König
2026-08-31 17:55 ` Mario Limonciello [this message]
2026-08-31 16:31 ` Ilpo Järvinen
2026-08-31 17:40 ` Geramy Loveless
2026-08-31 18:47 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d2e5f9f-1713-47a2-a5c3-d6385e691d2a@amd.com \
--to=mario.limonciello@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=gloveless@jqluv.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=meiling.leung@embeddedllm.com \
--cc=nra3088@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox