From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.11.231]:37513 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756428Ab3HMA4i convert rfc822-to-8bit (ORCPT ); Mon, 12 Aug 2013 20:56:38 -0400 Subject: Re: [PATCH 4/9] PCI: mvebu: add support for reset on GPIO Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <1376333215-12885-5-git-send-email-sebastian.hesselbarth@gmail.com> Date: Mon, 12 Aug 2013 19:56:33 -0500 Cc: Russell King , Jason Cooper , Andrew Lunn , Bjorn Helgaas , Thomas Petazzoni , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Message-Id: References: <1376333215-12885-1-git-send-email-sebastian.hesselbarth@gmail.com> <1376333215-12885-5-git-send-email-sebastian.hesselbarth@gmail.com> To: Sebastian Hesselbarth Sender: linux-pci-owner@vger.kernel.org List-ID: On Aug 12, 2013, at 1:46 PM, Sebastian Hesselbarth wrote: > This patch adds a check for DT passed reset-gpios property and deasserts/ > asserts reset pin on probe/remove with configurable delay. Corresponding > binding documentation is also updated. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Bjorn Helgaas > Cc: Thomas Petazzoni > Cc: devicetree@vger.kernel.org > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-pci@vger.kernel.org > --- > .../devicetree/bindings/pci/mvebu-pci.txt | 2 ++ > drivers/pci/host/pci-mvebu.c | 33 +++++++++++++++++++- > 2 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/mvebu-pci.txt b/Documentation/devicetree/bindings/pci/mvebu-pci.txt > index 638673a..f2fa261 100644 > --- a/Documentation/devicetree/bindings/pci/mvebu-pci.txt > +++ b/Documentation/devicetree/bindings/pci/mvebu-pci.txt > @@ -76,6 +76,8 @@ and the following optional properties: > - marvell,pcie-lane: the physical PCIe lane number, for ports having > multiple lanes. If this property is not found, we assume that the > value is 0. > +- reset-gpios: optional gpio to PERST# > +- reset-delay-ms: delay in ms to wait after reset de-assertion Both of these should probably be marvell,reset... Does reset-delay-ms vary per board? I can't remember where the discussion got to about configuration info. > > Example: It's usually good to update example to show all optional properties. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation